Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line Edits #96

Open
adammichaelwood opened this issue Aug 29, 2017 · 7 comments
Open

Line Edits #96

adammichaelwood opened this issue Aug 29, 2017 · 7 comments

Comments

@adammichaelwood
Copy link
Contributor

adammichaelwood commented Aug 29, 2017

This is a perpetual issue, never closed.

Typos sneak in, and branch-based editing makes it inconvenient to go chasing them every time you notice them. So...

If you are:

  • between issues
  • a little too sleepy in the afternoon to think about high-level stuff
  • a new comer looking for something to do

Start a line-edit branch, fix some typos, and submit a small PR.

Guidelines for line-edit PRs

  • Typos and basic fixes only; don't rewrite or move sections (You can rewrite or move sections, but that needs to be done in individual Issue-Discussion-PR cycles.)
    • Spelling
    • Punctuation
    • Basic grammar
    • Markup corrections
    • Fix links (external and cross references)
  • If you aren't sure, err on the side of not changing something
    • If something needs long task-oriented discussion, file an issue
    • If you need quick clarity on some point of confusion, use the docs-code channel on the ODK Slack
  • Run the build to make sure you didn't introduce errors
  • Don't use line edits to pursue personal grammar pet peeves
  • PR a single document at a time
  • line-edit PRs don't need a long description; the edits should speak for themselves
  • reference this issue number in your PR message, but don't say that it "closes" the issue
@mish24
Copy link
Contributor

mish24 commented Sep 8, 2017

@adammichaelwood Shall I work on this?

@adammichaelwood
Copy link
Contributor Author

Everyone can work on line edits at any time.
(Don't use the "Closes" syntax in your commit messages.)

@nadaa
Copy link
Contributor

nadaa commented Sep 9, 2017

Hi,
How can I start with this?
Thanks

@adammichaelwood
Copy link
Contributor Author

@nadaa

Read the contributor's guide. That provides instruction for setting up your local environment and getting started. Then just pick a file that has spelling or punctuation errors and fix them.

If you need help getting your tooling and authoring environment set up, talk to us on the developer slack, in the #docs-code channel.

@nadaa
Copy link
Contributor

nadaa commented Sep 9, 2017

Thank you @adammichaelwood.
I am following the contribution guide. I use windows (Cygwin) to setup the authoring tools, and I noticed there are no enough instructions in the guide. I will prepare a short doc to describe my approach.

Regards

@adammichaelwood
Copy link
Contributor Author

I use windows (Cygwin) to setup the authoring tools, and I noticed there are no enough instructions in the guide.

Yes. We need more details on the Windows experience. Most of us are Mac or Linux people, but we would like to encourage Windows users to contribute.

I will prepare a short doc to describe my approach.

Great. That would be very helpful.

IF you can incorporate that into the contributors guide, great. IF it makes more sense as a standalone doc, that would be fine too.

There's an issue for this: #95
We'd love for you to work on that.

@adammichaelwood
Copy link
Contributor Author

Quick note:

Please do not submit line edits for the Cygwin guide at this time, unless you are directly working on #159

@ankita240796 ankita240796 mentioned this issue Oct 23, 2017
This was referenced Oct 31, 2017
@ankita240796 ankita240796 mentioned this issue Dec 14, 2017
@ankita240796 ankita240796 mentioned this issue Jan 24, 2018
@apaluya apaluya mentioned this issue Jan 26, 2018
@richa208 richa208 mentioned this issue Jan 30, 2018
This was referenced Feb 10, 2018
@yanokwa yanokwa mentioned this issue Mar 9, 2018
@jchenj jchenj mentioned this issue Mar 27, 2020
yanokwa added a commit that referenced this issue Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants