error when running difd_1year_moisture0_veg0_fence1.txt

[christavanijzendoorn]

The following error occurs:
line 51, in initialize
s['fence_height'][:,:] = p['fence_file']
KeyError: 'fence_height'

[GlennStrypsteen]

The Aeolis model should be updated to the latest version. I resolved this issue some time ago by adding in the constants file 'fence_height': openearth/aeolis-python#98

[niketagrawal]

@GlennStrypsteen , thanks for the pointing out the root cause of the issue.

There are two ways to solve this issue:

1. Modify the conda environment file to install the latest version of AeoLiS from source from the GitHub repository instead of installing it from PyPI as shown below. This is the quick temporary solution.

name: aeolis_env
channels:
  - defaults
dependencies:
    - python=3.8
    - pip
    - jupyter
    - ffmpeg
    - git
    - pip:
        - git+https://github.com/openearth/aeolis-python

Creating a conda environment using the above environment file will install AeoLiS containing the latest commit on the main branch which includes the changes that Glenn mentioned. After updating the conda environment file as shown above, I was able to successfully run the difd_1year_moisture0_veg0_fence1 case.

2. Update the AeoLiS version on PyPI with the latest changes and keep the conda environment file unchanged.
   • This would require us to make a minor or patch release of AeoLiS from the git repository. Since the latest changes in the aeolis-python GitHub repository enable a new (backwards compatible?) functionality, I recommend making a new minor or patch release on PyPI. However, if we need more time to decide what goes in the next minor or patch release, we can opt for solution 1 for now.

What do you think @Sierd, @CarolineHalllin, @christavanijzendoorn, and @GlennStrypsteen?

[christavanijzendoorn]

Thanks Glenn and Niket! My preference would also be option 2, although I cannot fully estimate how much effort goes into making the minor or patch release.

[niketagrawal]

@christavanijzendoorn, the process of creation of a new release is automated in the repository, so it will be quick. We do need to manually update the docs/whatsnew.rst file prior to it and mention in it exactly what does this change imply for the users, and increment the version number accordingly.

[Sierd]

Thanks for pointing this out. Let's do a patch release to fix this.

[niketagrawal]

AeoLiS v2.1.1 was released yesterday. The issue is now fixed.