Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(test): test case to fetch specific snapshot information using target #292

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

mynktl
Copy link
Member

@mynktl mynktl commented Feb 28, 2020

fixes: openebs/openebs#2936
Signed-off-by: mayank mayank.patel@mayadata.io

Signed-off-by: mayank <mayank.patel@mayadata.io>
@mynktl
Copy link
Member Author

mynktl commented Feb 28, 2020

depends on openebs-archive/libcstor#46

EXPECT_EQ(snaplist->zvol_guid, std::stoul(output));
verify_snapshot_details(vol_name, snaplist->data, "");

// Try to fetch snapshot list using snapshot name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one more test to send wrong name in the snaplist command.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: mayank <mayank.patel@mayadata.io>
Copy link

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

Copy link
Member

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Have megred the libcstor PR and started the travis build for this. Will merge it once travis passes.

@pawanpraka1 pawanpraka1 merged commit f98416a into mayadata-io:develop Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rebuild estimate for cstor replica
3 participants