-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update react & react-dom to v17 #343
Merged
kenclary
merged 8 commits into
openedx:main
from
Mashal-m:mashal-m/react-upgrade-to-v17
Jul 31, 2023
Merged
feat: update react & react-dom to v17 #343
kenclary
merged 8 commits into
openedx:main
from
Mashal-m:mashal-m/react-upgrade-to-v17
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 226 226
Lines 4018 4018
Branches 797 797
=======================================
Hits 3630 3630
Misses 369 369
Partials 19 19 ☔ View full report in Codecov by Sentry. |
…t-components into mashal-m/react-upgrade-to-v17
…t-components into mashal-m/react-upgrade-to-v17
kenclary
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, looks right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade React JS to v17
Description
react
&react-dom
to v17 along withreact-test-renderer
to respective compatible versionsenzyme-adapter-react-16
with@wojtekmaj/enzyme-adapter-react-17
paragon
to fix react-loading-skeleton issue@edx/frontend-platform