Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show advanced settings button color #417

Conversation

Lunyachek
Copy link

Cosmetic adjustment: We removed the 'text-info-500' class that was conflicting with the styles of the 'Show advanced settings' button, preventing us from applying a different color to it. We believe that the 'text-info-500' class is unnecessary for this button. Even without this class, the button will appear correctly, and you'll still have the ability to change its color in branded themes.

Without a specific theme, we don't have a difference with or without this class
Снимок экрана 2023-11-02 в 18 20 45
Снимок экрана 2023-11-02 в 18 21 20

But with branded theme this fix will help us to override blue color with custom brand color
Снимок экрана 2023-11-02 в 18 24 38

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 2, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 2, 2023

Thanks for the pull request, @Lunyachek!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Nov 2, 2023
@e0d
Copy link

e0d commented Nov 6, 2023

@Lunyachek I invited you to the openedx-triage team on GitHub which will allow tests to run without approval, can you look for the invite in your email? It looks like there's a CI failure here though.

@mphilbrick211
Copy link

@Lunyachek I invited you to the openedx-triage team on GitHub which will allow tests to run without approval, can you look for the invite in your email? It looks like there's a CI failure here though.

Flagging this for you, @Lunyachek!

@mphilbrick211
Copy link

@Lunyachek I invited you to the openedx-triage team on GitHub which will allow tests to run without approval, can you look for the invite in your email? It looks like there's a CI failure here though.

Flagging this for you, @Lunyachek!

Hi @Lunyachek - friendly follow-up on this.

@mphilbrick211
Copy link

@Lunyachek I invited you to the openedx-triage team on GitHub which will allow tests to run without approval, can you look for the invite in your email? It looks like there's a CI failure here though.

Flagging this for you, @Lunyachek!

Hi @Lunyachek - friendly follow-up on this.

Hi @Lunyachek! Just checking in on this.

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Feb 21, 2024
@mphilbrick211 mphilbrick211 added closed inactivity PR was closed because the author abandoned it and removed inactive PR author has been unresponsive for several months labels Mar 21, 2024
@Lunyachek
Copy link
Author

@mphilbrick211 Sorry, it's my fault. I missed the updates on this pull request. Can it be reopened, or should I create a new pull request?

@mphilbrick211 mphilbrick211 reopened this Apr 2, 2024
@mphilbrick211
Copy link

Here you go, @Lunyachek!

@mphilbrick211 mphilbrick211 removed the closed inactivity PR was closed because the author abandoned it label Apr 2, 2024
@mphilbrick211
Copy link

Hi @Lunyachek - are you still planning to pursue this PR?

@KristinAoki
Copy link
Member

Hi! Thank you for your contribution to this repo. This repo is being deprecated and all the code is being moved to frontend-app-course-authoring. If you would like your work to be included in the transition please resolve outstanding requests for this PR. This PR will automatically close once frontend-app-course-authoring PR #1208 is merged.

@bradenmacdonald
Copy link
Contributor

As mentioned above, we've now moved this code into https://github.com/openedx/frontend-app-course-authoring/ so we'll need you to please re-open this PR against frontend-app-course-authoring if you'd like to continue it. Feel free to reach out to me if you aren't sure how to do that using git and I can help (basically: add your local content-components repo as a remote in course-authoring, then pull the branch and rebase it).

@openedx-webhooks
Copy link

@Lunyachek Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants