-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: layout responsive #422
Conversation
Thanks for the pull request, @ihor-romaniuk! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
=======================================
Coverage 90.49% 90.49%
=======================================
Files 228 228
Lines 4115 4115
Branches 822 822
=======================================
Hits 3724 3724
Misses 370 370
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Hi @openedx/teaching-and-learning @openedx/2u-tnl! Would someone be able to please review / merge this for us? Thanks! |
Hi @openedx/2u-tnl! Would someone be able to please review / merge this for us? Thanks! |
@KristinAoki would it be possible to check and merge this fix and backport PR from your side? Thank you! |
Hi @KristinAoki @GlugovGrGlib - just following up on this! |
@GlugovGrGlib or @ihor-romaniuk can you resolve the conflicts? |
Hi! Thank you for your contribution to this repo. This repo is being deprecated and all the code is being moved to |
As mentioned above, we've now moved this code into https://github.com/openedx/frontend-app-course-authoring/ so we'll need you to please re-open this PR against |
Pull request was closed
@ihor-romaniuk Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
@ihor-romaniuk FYI above. |
TL;DR -
This pull request contains mobile phone adaptation fixes for Problem Editor templates.
Added general rearrangement of pages, indentations, and fixed element deformation during adaptation.
What changed?