-
Notifications
You must be signed in to change notification settings - Fork 422
Conversation
@@ -451,7 +451,7 @@ dev.shell.analyticsapi: | |||
docker exec -it edx.devstack.analyticsapi env TERM=$(TERM) /edx/app/analytics_api/devstack.sh open | |||
|
|||
dev.shell.insights: | |||
docker-compose exec insights env TERM=$(TERM) bash -c 'eval $$(source /edx/app/insights/insights_env; echo PATH="$$PATH";) && /edx/app/insights/devstack.sh open' | |||
docker-compose exec insights env TERM=$(TERM) bash -c 'eval $$(source /edx/app/insights/insights_env; echo PATH="$$PATH";) && /bin/bash' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have removed the devstack.sh
file usage in the newer image.
Essentially the file was running these commands in this step:
. /edx/app/insights/nodeenvs/insights/bin/activate . /edx/app/insights/venvs/insights/bin/activate cd /edx/app/insights/insights /bin/bash
We have already done all these above steps by setting the WORKDIR in docker image and also putting the nodeenv and python virtual env in path.
things are going wrong as I test in ways that seem beyond my lack of docker expertise - short version is /edx/app/insights/insights/ seems to now be at /edx/app/insights/edx_analytics_dashboard/ and a few things need to be changed accordingly. That move seems to be part of openedx-unsupported/edx-analytics-dashboard#1333 what follows is what I did thrashing around with my limited docker experience in devstack: changed my docker-compose to then I removed the local checkout and insights would not come up: when I went to the insights shell I found that there was no Searching for insights/insights I changed the call in so I go to provision again and find that the provision script also points at insights/insights and has to be changed to point at insights/edx_analytics_dashboard which goes fine until it has to talk to the lms to provision. The provision script recreates the lms container and seems to break it: but dev.up.lms works fine by itself, it's only the provision script that brings up a mangled container. I went through the rest of provisioning manually and that seems to work, and then reprovisioned the analytics API. Also had to make static directly in the container after trying to just use the command in the weirdly broken provisioning flow, that does not seem to have actually webpacked right. I'm not sure what's going on there. So eventually I got it running but I'm pretty sure that these two repos have to agree on insights/insights vs insights/edx_analytics_dashboard/ and that ends up in a weird number of places. It's unfortunate insights was ever named differently than the repo name but that's long in the past. |
@ashultz0 Can you please explain a bit more about the steps that you performed while testing this and what checkout are you talking about? |
a006b8c
to
1bacc82
Compare
@aht007 the checkout is that because I've done a bunch of work on insights in the past year I had an existing insights checkout, so my initial run was just on that and then I moved it out of the way to try to use the provided dashboard. Maybe the only way to test this would be on a completely clean devstack but I was hoping to spend less than a day on the test. |
@ashultz0 Maybe your checkout somehow messed up with the mounted directory at |
I'm trying to make a separate clean devstack locally to test, we'll see if that works or if they just get tangled together at the docker layer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it got a bit tangled but I think I understand how it got tangled trying to be clean last time as well as having some more ammunition for why we should fix devstack... and in the end insights is up and running ok.
* feat: insights-configuration for docker
I've completed each of the following or determined they are not applicable: