-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade Python requirements #452
Merged
irtazaakram
merged 2 commits into
master
from
repo-tools/upgrade-python-requirements-eb0c9c2
Nov 11, 2024
Merged
chore: Upgrade Python requirements #452
irtazaakram
merged 2 commits into
master
from
repo-tools/upgrade-python-requirements-eb0c9c2
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of packages in the PR without any issue.
|
irtazaakram
approved these changes
Nov 11, 2024
irtazaakram
deleted the
repo-tools/upgrade-python-requirements-eb0c9c2
branch
November 11, 2024 06:25
regisb
pushed a commit
to regisb/edx-notes-api
that referenced
this pull request
Nov 14, 2024
* chore: Upgrade Python requirements * fix: trivy action failure --------- Co-authored-by: Irtaza Akram <irtaza.akram@arbisoft.com>
regisb
pushed a commit
to regisb/edx-notes-api
that referenced
this pull request
Nov 14, 2024
* chore: Upgrade Python requirements * fix: trivy action failure --------- Co-authored-by: Irtaza Akram <irtaza.akram@arbisoft.com>
irtazaakram
added a commit
that referenced
this pull request
Nov 14, 2024
* chore: Update catalog.yaml file for release data * chore: Delete openedx.yaml file * fix: refactor workflows * chore: Upgrade Python requirements (#450) * fix: path import is fixed After upgrading path-py from 9.1 to 12.5.0 they upgrade the import as well from p to capital P as import path from Path * fix: enable quality checks * chore: Upgrade Python requirements (#452) * chore: Upgrade Python requirements * fix: trivy action failure --------- Co-authored-by: Irtaza Akram <irtaza.akram@arbisoft.com> * feat: meilisearch backend for notes search (#444) * feat: introduce "make compile-requirement" target This is convenient to compile dependencies without upgrading them. * chore: simplify tox/make test commands This makes it possible to run the make commands directly without going through tox (though tox targets keep working, of course). * chore: more convenient unit test running Previously, it was not possible to run unit tests locally without manually creating mysql & elasticsearch containers. Here, we create a `make pytest` target that automatically starts the required containers. * chore: refactor views for better mysql/es separation Instead of checking a boolean flag in multiple different places, we use class inheritance. This makes it possible to later override the view and implement our own using a different search backend, such as Meilisearch. * feat: meilisearch backend for notes search This is a very simple and basic backend. It is based on Django signals, just like the Elasticsearch backend. But it is much simpler, in the sense that there are just two signals: one for saving documents and one for deletion. This backend is limited, in the sense that it does not support highlighting -- but that's probably not such a big deal. To start using this backend, define the following settings: ES_DISABLED = True MEILISEARCH_ENABLED = True MEILISEARCH_URL = "http://meilisearch:7700" MEILISEARCH_API_KEY = "s3cr3t" MEILISEARCH_INDEX = "tutor_student_notes" --------- Co-authored-by: salman2013 <salman.nawaz@arbisoft.com> Co-authored-by: Irtaza Akram <irtaza.akram@arbisoft.com> Co-authored-by: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com> Co-authored-by: Muhammad Arslan <arslan.abdulrauf@arbisoft.com> Co-authored-by: Irtaza Akram <51848298+irtazaakram@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python requirements update. Please review the changelogs for the upgraded packages.