Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multi-policy resolution #240

Merged
merged 1 commit into from
Aug 18, 2023
Merged

feat: multi-policy resolution #240

merged 1 commit into from
Aug 18, 2023

Conversation

johnnagro
Copy link
Contributor

@johnnagro johnnagro commented Aug 17, 2023 •
edited
Loading

Description

  • https://2u-internal.atlassian.net/browse/ENT-7484
  • when multiple redeemable policies are present, resolve them first by type, then expiration date, then balance
  • utilize RequestCache to avoid multiple round-trips to subsidy service
  • gate this experimental functionality behind a setting, allowing us to observe performance in a controlled fashion on STAGE

alex-sheehan-edx
alex-sheehan-edx approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense to me? ¯\_(ツ)_/¯

iloveagent57
iloveagent57 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is there an existing test case somewhere that the priority is respected above the expiration date and balance?

@johnnagro
Copy link
Contributor Author

LGTM! Is there an existing test case somewhere that the priority is respected above the expiration date and balance?

I'll add one for priority - preexisting code and i assumed it was there but dont see one.

@johnnagro johnnagro merged commit 54ced61 into main Aug 18, 2023
2 checks passed
@johnnagro johnnagro deleted the johnnagro/ENT-7484/0 branch August 18, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveagent57 iloveagent57 iloveagent57 approved these changes

@alex-sheehan-edx alex-sheehan-edx alex-sheehan-edx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnnagro @iloveagent57 @alex-sheehan-edx