feat: add nudge braze email using commands #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brobro10000
force-pushed
the
hu/ent-8166
branch
9 times, most recently
from
9fa20d4
to
fc242fb
Compare
brobro10000
commented
Jan 22, 2024
| @@ -104,7 +104,7 @@ class AssignmentAutomaticExpiredReason: | |||
| """ | |||
| Reason for assignment automatic expiry. | |||
| """ | |||
| NIENTY_DAYS_PASSED = 'NIENTY_DAYS_PASSED' | |||
| NINETY_DAYS_PASSED = 'NINETY_DAYS_PASSED' | |||
There was a problem hiding this comment.
Noticed a typo in this constant, refactored all cases where its used with the correct spelling for the value and variable
brobro10000
force-pushed
the
hu/ent-8166
branch
2 times, most recently
from
e8ece62
to
af3d2ed
Compare
brobro10000
force-pushed
the
hu/ent-8166
branch
5 times, most recently
from
5cba6e6
to
c62d751
Compare
brobro10000
force-pushed
the
hu/ent-8166
branch
from
c62d751
to
c735a39
Compare
iloveagent57
requested changes
Jan 23, 2024
...prise_access/apps/content_assignments/management/commands/automatically_nudge_assignments.py
Outdated
Show resolved
Hide resolved
...prise_access/apps/content_assignments/management/commands/automatically_nudge_assignments.py
Outdated
Show resolved
Hide resolved
...prise_access/apps/content_assignments/management/commands/automatically_nudge_assignments.py
Outdated
Show resolved
Hide resolved
...s/apps/content_assignments/management/commands/tests/test_automatically_nudge_assignments.py
Outdated
Show resolved
Hide resolved
...prise_access/apps/content_assignments/management/commands/automatically_nudge_assignments.py
Show resolved
Hide resolved
...s/apps/content_assignments/management/commands/tests/test_automatically_nudge_assignments.py
Outdated
Show resolved
Hide resolved
This is the main thing to fix (plus tests) and the reason for requesting changes. |
|
Ah, I misunderstood the intent here. The fact that we're sending reminders made me think you wanted allocated assignments. But you actually do want accepted ones. Let's take this conv off github for now, I think there's some nuance here. |
brobro10000
force-pushed
the
hu/ent-8166
branch
5 times, most recently
from
55c6222
to
456b4e5
Compare
brobro10000
force-pushed
the
hu/ent-8166
branch
from
456b4e5
to
03ff109
Compare
brobro10000
force-pushed
the
hu/ent-8166
branch
8 times, most recently
from
c11dcf9
to
4c9dba8
Compare
brobro10000
force-pushed
the
hu/ent-8166
branch
from
4c9dba8
to
e1d2c2d
Compare
Comment on lines
176
to
204
| class LearnerContentAssignmentNudgeRequestSerializer(serializers.Serializer): | ||
| """ | ||
| Request serializer to validate nudge endpoint query params. | ||
|
|
||
| For view: LearnerContentAssignmentAdminViewSet.nudge | ||
| """ | ||
| assignment_uuids = serializers.ListField( | ||
| child=serializers.UUIDField(), | ||
| allow_empty=False | ||
| ) | ||
| days_before_course_start_date = serializers.IntegerField( | ||
| min_value=1 | ||
| ) | ||
|
|
||
|
|
||
| class LearnerContentAssignmentNudgeResponseSerializer(serializers.Serializer): | ||
| """ | ||
| Response serializer for nudge endpoint. | ||
|
|
||
| For view: LearnerContentAssignmentAdminViewSet.nudge | ||
| """ | ||
| nudged_assignment_uuids = serializers.ListField( | ||
| child=serializers.UUIDField(), | ||
| ) | ||
| unnudged_assignment_uuids = serializers.ListField( | ||
| child=serializers.UUIDField(), | ||
| ) | ||
|
|
||
|
|
enterprise_access/apps/api/v1/views/content_assignments/assignments_admin.py
Outdated
Show resolved
Hide resolved
enterprise_access/apps/content_assignments/content_metadata_api.py
Outdated
Show resolved
Hide resolved
...prise_access/apps/content_assignments/management/commands/automatically_nudge_assignments.py
Show resolved
Hide resolved
...s/apps/content_assignments/management/commands/tests/test_automatically_nudge_assignments.py
Show resolved
Hide resolved
brobro10000
force-pushed
the
hu/ent-8166
branch
3 times, most recently
from
11a2d75
to
5e9d818
Compare
brobro10000
force-pushed
the
hu/ent-8166
branch
from
5e9d818
to
197af37
Compare
iloveagent57
approved these changes
Jan 30, 2024
Comment on lines
353
to
394
| @extend_schema( | ||
| tags=[CONTENT_ASSIGNMENT_ADMIN_CRUD_API_TAG], | ||
| summary='Nudge assignments by UUID.', | ||
| request=LearnerContentAssignmentNudgeRequestSerializer, | ||
| parameters=None, | ||
| responses={ | ||
| status.HTTP_200_OK: LearnerContentAssignmentNudgeResponseSerializer, | ||
| status.HTTP_422_UNPROCESSABLE_ENTITY: None, | ||
| } | ||
| ) | ||
| @permission_required(CONTENT_ASSIGNMENT_ADMIN_WRITE_PERMISSION, fn=assignment_admin_permission_fn) | ||
| @action(detail=False, methods=['post']) | ||
| def nudge(self, request, *args, **kwargs): | ||
| """ | ||
| Send nudges to a list of learners with associated ``LearnerContentAssignment`` | ||
| record by list of uuids. | ||
|
|
||
| ``` | ||
| Raises: | ||
| 400 If assignment_uuids list length is 0 or the value for days_before_course_start_date is less than 1 | ||
| 422 If the nudge_assignments call fails for any other reason | ||
| ``` | ||
| """ | ||
| serializer = LearnerContentAssignmentNudgeRequestSerializer(data=request.data) | ||
| serializer.is_valid(raise_exception=True) | ||
| assignment_configuration_uuid = self.requested_assignment_configuration_uuid | ||
| assignments = self.get_queryset().filter( | ||
| assignment_configuration__uuid=assignment_configuration_uuid, | ||
| uuid__in=serializer.data['assignment_uuids'], | ||
| ) | ||
| days_before_course_start_date = serializer.data['days_before_course_start_date'] | ||
| try: | ||
| result = assignments_api.nudge_assignments( | ||
| assignments, | ||
| assignment_configuration_uuid, | ||
| days_before_course_start_date | ||
| ) | ||
| response_serializer = LearnerContentAssignmentNudgeResponseSerializer(data=result) | ||
| response_serializer.is_valid(raise_exception=True) | ||
| return Response(data=response_serializer.data, status=status.HTTP_200_OK) | ||
| except Exception: # pylint: disable=broad-except | ||
| return Response(status=status.HTTP_422_UNPROCESSABLE_ENTITY) |
There was a problem hiding this comment.
This is a really, really well-factored and well-documented view, with really clear validation and abstractions around our business logic. Nice work, hang this on your fridge!
enterprise_access/apps/content_assignments/content_metadata_api.py
Outdated
Show resolved
Hide resolved
brobro10000
force-pushed
the
hu/ent-8166
branch
7 times, most recently
from
8949677
to
8ccb407
Compare
brobro10000
force-pushed
the
hu/ent-8166
branch
from
8ccb407
to
937d012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a command to send nudge emails to accepted assignments that are 14 and 30 days in advance for only executive education courses.