-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ENABLE_GRADING_METHOD_IN_PROBLEMS
feature flag
#932
feat: add ENABLE_GRADING_METHOD_IN_PROBLEMS
feature flag
#932
Conversation
Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #932 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 571 571
Lines 10188 10188
Branches 2210 2210
=======================================
Hits 9367 9367
Misses 794 794
Partials 27 27 ☔ View full report in Codecov by Sentry. |
Hi @openedx/2u-tnl! This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested turning this new feature on/off for the new problem editors, and it worked as expected (we used a quince environment).
Thank you :)
Hi @openedx/2u-tnl, Could you take a look at this PR? Thanks! |
@BryanttV is this good to merge? |
Hi @KristinAoki, yes, that would be perfect. Thank you! |
@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds the feature flag to enable the grading method feature in problems. This feature flag is used in this PR.
Important
These are the last PRs needed to add support to the MFE for the Configurable grading method for problems with multiple attempts
Supporting information
These changes are part of the effort made to implement Configurable grading method for problems with multiple attempts
Testing instructions
All instructions in this PR.