Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ENABLE_GRADING_METHOD_IN_PROBLEMS feature flag #932

Merged

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Apr 3, 2024

Description

This PR adds the feature flag to enable the grading method feature in problems. This feature flag is used in this PR.

Important

These are the last PRs needed to add support to the MFE for the Configurable grading method for problems with multiple attempts

Supporting information

These changes are part of the effort made to implement Configurable grading method for problems with multiple attempts

Testing instructions

All instructions in this PR.

@BryanttV BryanttV requested a review from a team as a code owner April 3, 2024 14:41
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 3, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (5247ec5) to head (0e8cd42).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files         571      571           
  Lines       10188    10188           
  Branches     2210     2210           
=======================================
  Hits         9367     9367           
  Misses        794      794           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Apr 3, 2024
@mphilbrick211
Copy link

Hi @openedx/2u-tnl! This is ready for review.

Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested turning this new feature on/off for the new problem editors, and it worked as expected (we used a quince environment).

Thank you :)

@BryanttV
Copy link
Contributor Author

Hi @openedx/2u-tnl, Could you take a look at this PR? Thanks!
@brian-smith-tcril, @arbrandes, I don't know if you can also help me with a review, I would appreciate it very much!

@mphilbrick211 mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label May 1, 2024
@KristinAoki
Copy link
Member

@BryanttV is this good to merge?

@BryanttV
Copy link
Contributor Author

BryanttV commented May 2, 2024

Hi @KristinAoki, yes, that would be perfect. Thank you!

@KristinAoki KristinAoki merged commit 2f5d4f7 into openedx:master May 3, 2024
6 checks passed
@openedx-webhooks
Copy link

@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants