Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's possible to vote for your own posts in Discussions MFE #688

Closed
DmytroAlipov opened this issue Apr 2, 2024 · 7 comments
Closed

It's possible to vote for your own posts in Discussions MFE #688

DmytroAlipov opened this issue Apr 2, 2024 · 7 comments
Labels
bug Report of or fix for something that isn't working as intended

Comments

@DmytroAlipov
Copy link
Contributor

The user has the opportunity to vote for his post:
screen_67

But if you look at how it worked for Discussion XBlock, you can see that the ability to vote for your post is blocked and the button is not active for the user:
screen_68

I found in the documentation that the user should not be able to vote for his post Discussions Docs

I found out that this resolution is obtained on the backend. But this is not used to Discussion MFE.

It might be worth paying attention to this.

@DmytroAlipov
Copy link
Contributor Author

Hi @jmakowski1123.
Perhaps you can suggest who works more closely with this MFE to consult on this issue.
thanks in advance.

@DmytroAlipov
Copy link
Contributor Author

Hi, @arbrandes.
Are you involved in this type of MFE? It's just that this bug can be fixed in different ways. Ideally, this should be done on the frontend. By analogy with Legacy. This is much more difficult to do on the backend. Since all paths lead to the Forum service. I need an expert opinion before fixing this bug. I would appreciate your advice.

@DmytroAlipov DmytroAlipov added the bug Report of or fix for something that isn't working as intended label May 31, 2024
@ayesha-waris
Copy link
Contributor

@DmytroAlipov Thanks for pointing out this bug, it will be resolved in this ticket

@DmytroAlipov
Copy link
Contributor Author

DmytroAlipov commented Jun 12, 2024

Hi, @ayesha-waris
Great news!
I have a request when they open an MR in the upstream, please link this MR to it.

@DmytroAlipov
Copy link
Contributor Author

@ayesha-waris
Can we not close this search for now? Could you close this when the MR in the upstream is ready?
Also, I have a question about the lack of information on this ticket. I don't have access to your Jira. That’s why I don’t know the state in which this ticket is located. Can you provide more information on this ticket? Also, I am wondering when you plan to work on it.
Thanks 😊

@ayesha-waris
Copy link
Contributor

@DmytroAlipov The ticket is in progress, I believe you will get notified once PR is shared for review as this issue will be mentioned in PR.

@DmytroAlipov
Copy link
Contributor Author

Hi @ayesha-waris
I’ve noticed that you’ve fixed the bug. This is indeed splendid news 🎉 I extend my deepest gratitude for your diligent efforts in making this correction.

If I may, I have an additional request. Would it be possible for you to create a backport to Redwood? Your assistance in this matter would be greatly appreciated.
Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants