-
Notifications
You must be signed in to change notification settings - Fork 25
Comments
Fixes for Video, Problem and HTML will likely come out of the new editors being developed for frontend-app-course-authoring. (The editors themselves are hosted in https://github.com/edx/frontend-lib-content-components/). We'll just need to make sure Studio is configured to use the new editors, and that this MFE is using the correct endpoint to fetch them. |
@arbrandes is correct. Our rollout of the new Text/HTML editor for Course Authoring was automatically applied to the Library Authoring context as well. This is also true for the new Video Settings Editor which is currently in Beta testing. I do not believe there will need to be anything special or unique done for these new editors to apply to the Library Authoring context. Based on that, @brian-smith-tcril do you still want to keep this issue open? |
@jristau1984, @brian-smith-tcril, see the Proposed Solution in the ticket description. We're going to need to import and use the new editors in this MFE, just like Course Authoring does. |
We are aware of this, and this integration work is part of the library authoring MFE rollout work that is currently being planned. We expect this to be completed in Q1 2023. Don't hesitate to reach out with any questions/comments/concerns. Thanks! |
@jristau1984, Any objections to us (as in @brian-smith-tcril) tackling this sooner rather than later? Is the work already in progress? |
What exactly are you proposing to do?
Thanks,
Jeremy Ristau
Engineering Manager - edX/2U
…On Fri, Jan 27, 2023 at 9:51 AM Adolfo R. Brandes ***@***.***> wrote:
@jristau1984 <https://github.com/jristau1984>, Any objections to us (as
in @brian-smith-tcril <https://github.com/brian-smith-tcril>) tackling
this sooner rather than later? Is the work already in progress?
—
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZ5NHU2HTTSNOOKSW62Q73WUPOFVANCNFSM6AAAAAAQWDAMWY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Yeah, see "Proposed Solution" above. Basically, to do here exactly what the Course Authoring MFE does: import the editors from |
Ahh, sorry I understand now you are proposing just the import portion of the work. That I have no issues with, but please coordinate with @connorhaugh as he is working on getting the library authoring MFE ready for beta test and I would prefer to not have duplicative updates. More info:
|
@arbrandes
|
To close the loop for now, v2 editors in the Library Authoring MFE is being delivered by 2U and is tracked internally with this epic: https://2u-internal.atlassian.net/browse/TNL-10513. This issue will likely remain open until that work is completed, please feel free to reach out to @jristau1984 with questions or other updates! |
If I'm not mistaken, this has now been solved, right? |
Closing it, as I believe the new editors all work, now. Feel free to reopen if needed. |
Some of the block types are not editable in the MFE (it's especially notable because of the 3 not in the "Advanced" dropdown, only 1 works)
Proposed solution
The fix for the Video, HTML, and Problem blocks is to use the new React-based editors. These editors are currently only usable via the Course Authoring MFE. If the corresponding waffle flags are enabled (for instance new_core_editors.use_new_text_editor), when the user edits the corresponding block in Studio, they are sent to the Course Authoring MFE.
The Course Authoring MFE, in turn, imports the editors themselves from frontend-lib-content-components. As an MFE in its own right, the Library Authoring MFE should do the same.
The text was updated successfully, but these errors were encountered: