Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

support running as a tutor plugin in production #99

Conversation

brian-smith-tcril
Copy link
Contributor

To test this locally, follow the updated instructions in the plugin README.rst
https://github.com/brian-smith-tcril/frontend-app-library-authoring/blob/tutor-prod/tutor-contrib-library-authoring-mfe/README.rst

Todos

  • Figure out where tutor-contrib-blockstore should live
  • Update README.rst to reference permanent tutor-contrib-blockstore location
  • Update plugin.py to point to openedx repo instead of fork
  • Remove version line in LIBRARY_AUTHORING_MFE_APP in plugin.py
  • Update README.rst to reference openedx repo for frontend-app-library-authoring instead of fork

@brian-smith-tcril brian-smith-tcril force-pushed the tutor-prod branch 2 times, most recently from 9c5ea0c to 7f4ed92 Compare January 11, 2023 23:44
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 49.12% // Head: 49.12% // No change to project coverage 👍

Coverage data is based on head (7f4ed92) compared to base (e40a982).
Patch has no changes to coverable lines.

❗ Current head 7f4ed92 differs from pull request most recent head 62468ea. Consider uploading reports for the commit 62468ea to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   49.12%   49.12%           
=======================================
  Files          76       76           
  Lines        2003     2003           
  Branches      372      372           
=======================================
  Hits          984      984           
  Misses        985      985           
  Partials       34       34           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized I never merged this! Apologies @brian-smith-tcril, and thanks!

@arbrandes arbrandes marked this pull request as ready for review June 15, 2023 15:21
@arbrandes arbrandes requested a review from a team as a code owner June 15, 2023 15:21
@arbrandes
Copy link
Contributor

Ah, but there are still TODO's. In particular, where the blockstore plugin should live. I think we should move both to https://github.com/openedx/openedx-tutor-plugins.

@arbrandes
Copy link
Contributor

Done via openedx/openedx-tutor-plugins#9

@arbrandes arbrandes closed this Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants