Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add grey color for disabled selects during the form submission #865

Conversation

Lunyachek
Copy link
Contributor

@Lunyachek Lunyachek commented Apr 9, 2024

This is backport from master - #715

Description

This cosmetic enhancement for payment form. After pressing "Place Order" button - we can see that all inputs became disabled, but selects - no. It looks not consistent and we decided to fix this small issue.

2023-03-06.11.53.26.mov

The result:

2023-03-02.14.43.17.mov

@Lunyachek Lunyachek requested a review from a team as a code owner April 9, 2024 11:03
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 9, 2024

Thanks for the pull request, @Lunyachek!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently unmaintained.

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:

  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 9, 2024
@Lunyachek Lunyachek force-pushed the lunyachek/fix/visual-enhancement-disabled-selects-quince branch from a212113 to c4468dd Compare April 9, 2024 11:05
@Lunyachek Lunyachek force-pushed the lunyachek/fix/visual-enhancement-disabled-selects-quince branch 2 times, most recently from a8a8763 to c454527 Compare April 9, 2024 21:05
@Lunyachek
Copy link
Contributor Author

The failed tests are not related to the changes in this PR. Can someone help troubleshoot this issue?

@mphilbrick211 mphilbrick211 removed the request for review from a team April 10, 2024 16:15
@feanil
Copy link
Contributor

feanil commented Apr 10, 2024

@Lunyachek it looks like the issue is that master has some dependencies that have security issues that are out of date and have known vulnerabilities in them that need to be resolved. Looks like the full test suite ran and passed so I think this is safe to merge so I'm gonna go ahead an approve and merge this. take a look at this PR.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Apr 10, 2024
@arbrandes
Copy link

To make sure we're all on the same page, we should only consider merging this PR after the one to master lands.

@feanil
Copy link
Contributor

feanil commented Apr 10, 2024

@arbrandes thanks for the catch, missed that this was on the quince branch, that explains the out of date dependencies. So in general, this should be safe to merge once the one on master lands.

@mphilbrick211
Copy link

To make sure we're all on the same page, we should only consider merging this PR after the one to master lands.

@arbrandes are you able to merge this now that the master is all set?

@ihor-romaniuk
Copy link

@arbrandes @mphilbrick211 I believe everything is ready for the final review and merging of this pull request into the quince branch. Could we proceed with that?

@mphilbrick211
Copy link

@arbrandes @mphilbrick211 I believe everything is ready for the final review and merging of this pull request into the quince branch. Could we proceed with that?

@arbrandes @brian-smith-tcril - is one of you able to take a look at this?

@brian-smith-tcril
Copy link
Contributor

The changes here look identical to the changes to master. I hadn't merged this before because of CI failures, but it seems they are just the allowlist errors that I noticed here. I'm happy to merge this as-is.

@brian-smith-tcril brian-smith-tcril merged commit 5f69acc into openedx:open-release/quince.master Sep 20, 2024
3 of 4 checks passed
@ihor-romaniuk ihor-romaniuk deleted the lunyachek/fix/visual-enhancement-disabled-selects-quince branch September 23, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants