This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
feat: 3DS checkout flow for subscriptions #773
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazadar
force-pushed
the
mrazadar/PON-161/checkout-3DS-flow
branch
from
July 19, 2023 19:35
a06cc02
to
5464385
Compare
mrazadar
changed the title
[WIP] - feat: 3DS checkout flow for subscriptions
feat: 3DS checkout flow for subscriptions
Jul 19, 2023
julianajlk
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work 👏 Thank you for adding comments throughout this very complicated flow, and for all of the testing with the BE
grmartin
added a commit
that referenced
this pull request
Aug 29, 2023
* chore(i18n): update translations * feat: added transaction_declined error handler (#756) * chore(i18n): update translations * feat: use `atlas` in `make pull_translations` (#732) Changes ------- - Bump frontend-platform to bring intl-imports.js script - Move all i18n imports into `src/i18n/index.js` so intl-imports.js can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58. * feat: removed the Localized Currency for subscription (#758) * PON-281: SDN error handling (#759) * feat: fixed the program_tile italic and subscribe checkout state * feat: added SDN error check with feedback saga * test: fixed borken tests * test: removed the screen.debug call * feat: do not display any error alert on the checkout page for sdn * fix: fixed the config name for feedback saga alert * Mrazadar/pon 178/unit test checkout (#760) * test: added stripe service unit test * test: added api service unit test * test: working on improving subscription checkout test * test: checkout test with react-testing-library * test: removed the commented code * feat: (PON-326) updated localize date for billing (#764) * refactor: the Legal support URL to used with env variable * feat: add localize date with billing information * test: fixed the broken tests * refactor: updated SUBSCRIPTION_LEGAL_URL with LEARNER_SUPPORT_URL * test: trying to fix the failing tests * test: fixed the broken tests * feat: update the LEARNER_SUPPORT_URL key * feat: no localize date for resubscribe case * fix: update allowlist to unblock translations pr (#767) * chore(i18n): update translations * feat: update react & react-dom to v17 (#761) * feat: update react & react-dom to v17 * build: update paragon version * refactor: updated edx packages * refactor: updated header, footer, frontend-build & semver packages to resolve vulnerabilities --------- Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com> * feat: 3DS checkout flow for subscriptions (#773) * feat: 3DS iframe with modal implementation * feat: 3DS removed commented code * feat: 3DS added a redirect page * feat: added subscription status saga methods * feat: setting up the 3DS status redux sagas * feat: handles the happy flow * feat: updates the error message * feat: updated styles as per stripe portal 3DS styles * test: updated tests for subscription/service.tests.js * test: added tests for subscriptions/data/utils * feat: updated Secure3DModal to handle stripe-checkout-complete response * feat: updated subscription status redux to handle stripe-checkout-complete * feat: incorporated PR feedback * test: added unit test for Secure3DModal * feat: fixed the broken styles * feat: added stripe redirect content-security-policy tag (#776) * Mrazadar/pon 161/content security fix (#777) * revert: the react-helmet * feat: added content-security-policy meta tag at the top * revert: removed the meta tag from index.html (#778) * feat: added new relic logs for 3ds (#784) * fix: Checkout Bulk purchase 'Max' alignment fixed (#781) * fix: Checkout Bulk purchase 'Max' alignment fixed * fix: Updated snapshots for cart & payment * test: added temp logs for testing 3ds (#785) * revert: removed the previously temporary new-relic logs * feat: added console logs for loading 3ds details * feat: removed previous logs and added new relic logs (#786) * feat: change console to logInfo * feat: added one more log * feat: sending program_uuid with stripe-checkout-complete (#788) * docs: add feedback.rst HOWTO (#782) * docs: include error handling in feedback.rst title * docs: move sub-TOCs to relevant sections for clarity * docs: move feedback.rst sections around * refactor: updated workflow (#775) * feat: added readme docs for subscription feature (#793) * feat: updating readme.md for subscription related work * feat: added subscription related docs * feat: fixed the code formatting * refactor: remove the new relic logs previously added for 3DS testing * feat: reverted the readme.rst changes --------- Co-authored-by: Jenkins <sre+jenkins@edx.org> Co-authored-by: Raza Dar <5585262+mrazadar@users.noreply.github.com> Co-authored-by: Omar Al-Ithawi <i@omardo.com> Co-authored-by: Juliana Kang <julianajlk@gmail.com> Co-authored-by: Mashal Malik <107556986+Mashal-m@users.noreply.github.com> Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com> Co-authored-by: Mobeen Ali <46916730+mobeenali12@users.noreply.github.com> Co-authored-by: Phillip Shiu <pshiu@edx.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: PON-161
This PR implements the 3DS workflow for both
trial
andnon-trial
mode.stripe-checkout-complete
endpoint to confirm the 3DS workflow has been done.