Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add catalog-info.yaml #965

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

@hamza-56 hamza-56 self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base (7b1f22b) to head (f0fcbf8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #965   +/-   ##
=======================================
  Coverage   67.76%   67.76%           
=======================================
  Files         128      128           
  Lines        3229     3229           
  Branches      913      935   +22     
=======================================
  Hits         2188     2188           
+ Misses        996      993    -3     
- Partials       45       48    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

catalog-info.yml Outdated
spec:
owner: group:2u-phoenix
type: 'service'
lifecycle: 'production'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add dependsOn for publisher, as it depends on course-discovery.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@AfaqShuaib09
Copy link
Contributor

I'm not sure if it is related, but there is a PR that changes the extension from .yml to .yaml openedx/frontend-app-learner-dashboard#388

@hamza-56 hamza-56 changed the title docs: add catalog-info.yml docs: add catalog-info.yaml Jul 24, 2024
Copy link
Contributor

@AfaqShuaib09 AfaqShuaib09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to squash the commits before merge

@DawoudSheraz DawoudSheraz merged commit 14ac1ab into openedx:master Jul 25, 2024
7 checks passed
@hamza-56 hamza-56 deleted the hamza/create-catalog-info branch July 26, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants