-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add catalog-info.yaml #965
docs: add catalog-info.yaml #965
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
=======================================
Coverage 67.76% 67.76%
=======================================
Files 128 128
Lines 3229 3229
Branches 913 935 +22
=======================================
Hits 2188 2188
+ Misses 996 993 -3
- Partials 45 48 +3 ☔ View full report in Codecov by Sentry. |
catalog-info.yml
Outdated
spec: | ||
owner: group:2u-phoenix | ||
type: 'service' | ||
lifecycle: 'production' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can add dependsOn for publisher, as it depends on course-discovery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
I'm not sure if it is related, but there is a PR that changes the extension from .yml to .yaml openedx/frontend-app-learner-dashboard#388 |
138ee9e
to
5c594ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to squash the commits before merge
https://open-edx-proposals.readthedocs.io/en/latest/processes/oep-0055/decisions/0001-use-backstage-to-support-maintainers.html