fix: update default time from 12:00 to 00:00 #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 67.77% 67.77%
=======================================
Files 128 128
Lines 3230 3230
Branches 936 937 +1
=======================================
Hits 2189 2189
+ Misses 996 993 -3
- Partials 45 48 +3 ☔ View full report in Codecov by Sentry. |
Ali-D-Akbar
approved these changes
Oct 10, 2024
| @@ -21,7 +21,7 @@ class DateTimeField extends React.Component { | |||
| : getDateWithDashes(this.props.input.value), | |||
| time: (this.props.utcTimeZone | |||
| ? getTimeStringUTC(this.props.input.value) | |||
| : getTimeString(this.props.input.value)) || '12:00', | |||
| : getTimeString(this.props.input.value)) || '12:00 AM', | |||
There was a problem hiding this comment.
Does this AM work out of the box? Should it not be 00:00?
There was a problem hiding this comment.
Yes, you're right.
Updated
hamza-56
force-pushed
the
hamza/PROD-4200
branch
from
43d47ed
to
56997aa
Compare
hamza-56
changed the title
DawoudSheraz
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4200