Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add users table #406

Merged
merged 3 commits into from
Sep 5, 2024
Merged

feat: add users table #406

merged 3 commits into from
Sep 5, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Aug 23, 2024

Description

As part of the enterprise setup support tool update, this PR adds a table containing all admins and learners:

Screen.Recording.2024-09-02.at.7.20.04.PM.mov

Test Plan on Stage

  1. checkout branch knguyen2/ent-9166 and run npm install
  2. at the root directory, add file webpack.dev.config.js with the following content:
const { createConfig } = require('@openedx/frontend-build');

module.exports = createConfig('webpack-dev', {
  devServer: {
    allowedHosts: 'all',
    https: true,
  },
});
  1. replace the content in .env.development with this info:
NODE_ENV='development'
PORT=18450
FEATURE_CUSTOMER_SUPPORT_VIEW='true'
ADMIN_PORTAL_BASE_URL='https://portal.stage.edx.org'
ACCESS_TOKEN_COOKIE_NAME='stage-edx-jwt-cookie-header-payload'
BASE_URL='https://localhost.stage.edx.org:18450'
FEATURE_CUSTOMER_SUPPORT_VIEW='true'
FEATURE_CONFIGURATION_MANAGEMENT='true'
FEATURE_CONFIGURATION_ENTERPRISE_PROVISION='true'
FEATURE_CONFIGURATION_EDIT_ENTERPRISE_PROVISION='true'
CREDENTIALS_BASE_URL='https://credentials.stage.edx.org'
CSRF_TOKEN_API_PATH='/csrf/api/v1/token'
ECOMMERCE_BASE_URL='https://ecommerce.stage.edx.org'
ENTERPRISE_ACCESS_BASE_URL='https://enterprise-access.stage.edx.org'
LANGUAGE_PREFERENCE_COOKIE_NAME='openedx-language-preference'
LMS_BASE_URL='https://courses.stage.edx.org'
LICENSE_MANAGER_URL='https://license-manager.stage.edx.org'
SUPPORT_CONFLUENCE='https://support-tools.edx.org'
SUPPORT_CUSTOMER_REQUEST='https://support-tools.edx.org'
DISCOVERY_API_BASE_URL='https://discovery.stage.edx.org'
LOGIN_URL='https://courses.stage.edx.org/login'
LOGOUT_URL='https://courses.stage.edx.org/logout'
LOGO_URL=https://edx-cdn.org/v3/default/logo.svg
LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg
LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg/
FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico
MARKETING_SITE_BASE_URL='https://stage.edx.org'
ORDER_HISTORY_URL='https://orders.stage.edx.org/orders'
REFRESH_ACCESS_TOKEN_ENDPOINT='https://courses.stage.edx.org/login_refresh'
SEGMENT_KEY=null
SITE_NAME='edX'
SUBSIDY_BASE_URL='https://enterprise-subsidy.stage.edx.org'
USER_INFO_COOKIE_NAME='edx-user-info'
PUBLISHER_BASE_URL='https://publisher.stage.edx.org/'
APP_ID='support-tools'
MFE_CONFIG_API_URL='https://courses.stage.edx.org/api/mfe_config/v1'
  1. use a testing enterprise such as https://localhost.stage.edx.org:18450/enterprise-configuration/customers/66b5922b-a22b-4a7b-b587-d4af0378bd6f/view

  2. verify that you can search by a user's username or email.

  3. verify that admins are ordered first and alphabetized followed by learners and alphabetized.
    Screenshot 2024-09-02 at 7 17 31 PM

https://2u-internal.atlassian.net/browse/ENT-9166

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 28 lines in your changes missing coverage. Please review.

Project coverage is 84.47%. Comparing base (6b3bb62) to head (5456ed3).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
.../Customers/data/hooks/useCustomerUsersTableData.js 21.21% 18 Missing and 8 partials ⚠️
src/data/services/EnterpriseApiService.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   84.96%   84.47%   -0.49%     
==========================================
  Files         182      185       +3     
  Lines        3752     3814      +62     
  Branches      909      919      +10     
==========================================
+ Hits         3188     3222      +34     
- Misses        550      570      +20     
- Partials       14       22       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple things!

@katrinan029 katrinan029 force-pushed the knguyen2/ent-9166 branch 3 times, most recently from 37c55d1 to d0f4897 Compare September 5, 2024 17:26
@katrinan029 katrinan029 merged commit 89a3569 into master Sep 5, 2024
6 of 8 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9166 branch September 5, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants