feat: Removed IDV Status details call #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
==========================================
+ Coverage 84.49% 84.72% +0.23%
==========================================
Files 185 185
Lines 3817 3849 +32
Branches 912 947 +35
==========================================
+ Hits 3225 3261 +36
+ Misses 570 566 -4
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Ali-D-Akbar
approved these changes
Sep 12, 2024
rijuma
force-pushed
the
rijuma/remove-verification-attempt-status-call
branch
from
cb1db29
to
6ea7026
Compare
rijuma
force-pushed
the
rijuma/remove-verification-attempt-status-call
branch
from
6ea7026
to
11b6bea
Compare
MichaelRoytman
approved these changes
Sep 13, 2024
zawan-ila
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this change on
edx-name-affirmation(edx/edx-name-affirmation#215), the status for the IDV attempt status was added to the payload for the Verified Name History endpoint. This change removes the need for using the account verification detail to get the attempt status.I've also tweaked the tooltip to make it a bit nicer on the UI and formatted properly for human readability.
Screenshots