Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined set selection for image modal #384

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

KristinAoki
Copy link
Member

JIRA Ticket: TNL-11042

setSelection was given the default prop undefined and they carried over to all children components. However, the setSelection function is not a prop passed to th etinyMceWidget instead it is initialized in hooks.js and passed back to the main index file.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8fe8bc1) 90.58% compared to head (c8f50d0) 90.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         230      230           
  Lines        4109     4109           
  Branches      824      824           
=======================================
  Hits         3722     3722           
  Misses        366      366           
  Partials       21       21           
Files Changed Coverage Δ
...c/editors/sharedComponents/TinyMceWidget/index.jsx 94.44% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit 9ebe187 into main Sep 6, 2023
6 checks passed
@jesperhodge jesperhodge mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants