fix: default display of "Show Answer" and "Show reset option"

[DmytroAlipov]

Description:

I created the issue.
Hardcoding values for showAnswer and showResetButton in initialState leads to incorrect selection of additional states specified in Advanced settings.

Advanced Settings:

Editor Page:

But the inscription Default is correctly attributed:

If you save without changing anything, the value of the Show answer field for the course will be set to Finished(although the default is “closed”, we didn’t change anything in the selection). And this problem is not only with this field. The same behavior for the Show reset option field.

The problem is that the state is being used (frontend-lib-content-components/src/editors/data/redux/problem/reducers.js):

const initialState = {
  rawOLX: '',
  problemType: null,
  question: '',
  answers: [],
  correctAnswerCount: 0,
  groupFeedbackList: [],
  generalFeedback: '',
  additionalAttributes: {},
  defaultSettings: {},
  settings: {
    randomization: null,
    scoring: {
      weight: 1,
      attempts: {
        unlimited: true,
        number: '',
      },
    },
    hints: [],
    timeBetween: 0,
    showAnswer: {
      on: ShowAnswerTypesKeys.FINISHED,
      afterAttempts: 0,
    },
    showResetButton: false,
    solutionExplanation: '',
    tolerance: {
      value: null,
      type: ToleranceTypes.none.type,
    },
  },
};

For Show reset option:

[openedx-webhooks]

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[e0d]

@DmytroAlipov seeing some linting failures.

[DmytroAlipov]

@e0d I have fixed the linting issues. Although my changes only addressed one error, the other errors were related to the code written before me. It's strange that the checks passed previously.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60439d5) 90.50% compared to head (3f8e6e3) 90.51%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   90.50%   90.51%           
=======================================
  Files         227      227           
  Lines        4108     4110    +2     
  Branches      823      825    +2     
=======================================
+ Hits         3718     3720    +2     
  Misses        369      369           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mphilbrick211]

Hi @openedx/teaching-and-learning! This is ready for review :)

[KristinAoki]

@DmytroAlipov Can you resolve the branch conflicts so I can merge the PR?

[DmytroAlipov]

@KristinAoki done 😉

[openedx-webhooks]

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.