Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixed delete for additional video url fields #418

Conversation

vladislavkeblysh
Copy link
Contributor

  • Fixed delete for additional video url fields

Screenshot 2023-11-05 at 14 38 46

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 5, 2023

Thanks for the pull request, @vladislavkeblysh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 5, 2023
@vladislavkeblysh vladislavkeblysh changed the title feat: fixed delete button feat: Fixed delete for additional video url fields Nov 5, 2023
@mphilbrick211
Copy link

Hi @vladislavkeblysh! Looks like there's a failing check - would you mind taking a look?

@vladislavkeblysh
Copy link
Contributor Author

@mphilbrick211 Fixed

@mphilbrick211
Copy link

@mphilbrick211 Fixed

There's still a failing check - let me know if you're having issues clearing it, and I can look into it for you. Thanks!

@mphilbrick211
Copy link

@mphilbrick211 Fixed

There's still a failing check - let me know if you're having issues clearing it, and I can look into it for you. Thanks!

Friendly ping on this, @vladislavkeblysh!

@mphilbrick211
Copy link

Hi @vladislavkeblysh! Just checking in to see if you plan to pursue this pull request? If not, we can close for now and reopen at a later time.

@vladislavkeblysh
Copy link
Contributor Author

@mphilbrick211 still in progress, will be fixed soon, ty

@vladislavkeblysh
Copy link
Contributor Author

@mphilbrick211 Fixed

@mphilbrick211 mphilbrick211 requested a review from a team April 23, 2024 14:46
@mphilbrick211
Copy link

Hi @openedx/2u-tnl! This is ready for review.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label May 2, 2024
@KristinAoki
Copy link
Member

@vladislavkeblysh in the description can you put a more in depth description of the bug that is being fixed?

@mphilbrick211
Copy link

@vladislavkeblysh in the description can you put a more in depth description of the bug that is being fixed?

@vladislavkeblysh - friendly follow-up on this!

@mphilbrick211 mphilbrick211 added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Jul 17, 2024
@KristinAoki
Copy link
Member

Hi! Thank you for your contribution to this repo. This repo is being deprecated and all the code is being moved to frontend-app-course-authoring. If you would like your work to be included in the transition please resolve outstanding requests for this PR. This PR will automatically close once frontend-app-course-authoring PR #1208 is merged.

@bradenmacdonald
Copy link
Contributor

As mentioned above, we've now moved this code into https://github.com/openedx/frontend-app-course-authoring/ so we'll need you to please re-open this PR against frontend-app-course-authoring if you'd like to continue it. Feel free to reach out to me if you aren't sure how to do that using git and I can help (basically: add your local content-components repo as a remote in course-authoring, then pull the branch and rebase it).

@openedx-webhooks
Copy link

@vladislavkeblysh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@mphilbrick211
Copy link

As mentioned above, we've now moved this code into https://github.com/openedx/frontend-app-course-authoring/ so we'll need you to please re-open this PR against frontend-app-course-authoring if you'd like to continue it. Feel free to reach out to me if you aren't sure how to do that using git and I can help (basically: add your local content-components repo as a remote in course-authoring, then pull the branch and rebase it).

@vladislavkeblysh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants