-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fixed delete for additional video url fields #418
feat: Fixed delete for additional video url fields #418
Conversation
vladislavkeblysh
commented
Nov 5, 2023
- Fixed delete for additional video url fields
Thanks for the pull request, @vladislavkeblysh! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @vladislavkeblysh! Looks like there's a failing check - would you mind taking a look? |
@mphilbrick211 Fixed |
There's still a failing check - let me know if you're having issues clearing it, and I can look into it for you. Thanks! |
Friendly ping on this, @vladislavkeblysh! |
Hi @vladislavkeblysh! Just checking in to see if you plan to pursue this pull request? If not, we can close for now and reopen at a later time. |
@mphilbrick211 still in progress, will be fixed soon, ty |
@mphilbrick211 Fixed |
Hi @openedx/2u-tnl! This is ready for review. |
@vladislavkeblysh in the description can you put a more in depth description of the bug that is being fixed? |
@vladislavkeblysh - friendly follow-up on this! |
Hi! Thank you for your contribution to this repo. This repo is being deprecated and all the code is being moved to |
As mentioned above, we've now moved this code into https://github.com/openedx/frontend-app-course-authoring/ so we'll need you to please re-open this PR against |
@vladislavkeblysh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
|