Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: layout responsive #422

Closed

Conversation

ihor-romaniuk
Copy link
Contributor

TL;DR -

This pull request contains mobile phone adaptation fixes for Problem Editor templates.
Added general rearrangement of pages, indentations, and fixed element deformation during adaptation.

What changed?

  • Select problem type page
Before After
image image
  • Select problem type page (advanced problems)
Before After
image image
  • Inner problem page
Before After
image image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 23, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 23, 2023

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (3aa9088) to head (84e9c13).
Report is 94 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         228      228           
  Lines        4115     4115           
  Branches      822      822           
=======================================
  Hits         3724     3724           
  Misses        370      370           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ihor-romaniuk ihor-romaniuk requested review from jesperhodge, rayzhou-bit and connorhaugh and removed request for jesperhodge and rayzhou-bit November 24, 2023 16:20
@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning @openedx/2u-tnl! Would someone be able to please review / merge this for us? Thanks!

@mphilbrick211 mphilbrick211 requested a review from a team February 21, 2024 15:08
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
@mphilbrick211 mphilbrick211 requested review from a team and removed request for a team March 21, 2024 01:37
@mphilbrick211
Copy link

Hi @openedx/2u-tnl! Would someone be able to please review / merge this for us? Thanks!

@GlugovGrGlib
Copy link
Member

@KristinAoki would it be possible to check and merge this fix and backport PR from your side? Thank you!

@mphilbrick211
Copy link

Hi @KristinAoki @GlugovGrGlib - just following up on this!

@KristinAoki
Copy link
Member

KristinAoki commented Aug 1, 2024

@GlugovGrGlib or @ihor-romaniuk can you resolve the conflicts?

@KristinAoki KristinAoki enabled auto-merge (squash) August 1, 2024 17:18
@KristinAoki KristinAoki added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Aug 16, 2024
@KristinAoki
Copy link
Member

Hi! Thank you for your contribution to this repo. This repo is being deprecated and all the code is being moved to frontend-app-course-authoring. If you would like your work to be included in the transition please resolve outstanding requests for this PR. This PR will automatically close once frontend-app-course-authoring PR #1208 is merged.

@bradenmacdonald
Copy link
Contributor

As mentioned above, we've now moved this code into https://github.com/openedx/frontend-app-course-authoring/ so we'll need you to please re-open this PR against frontend-app-course-authoring if you'd like to continue it. Feel free to reach out to me if you aren't sure how to do that using git and I can help (basically: add your local content-components repo as a remote in course-authoring, then pull the branch and rebase it).

auto-merge was automatically disabled August 29, 2024 19:11

Pull request was closed

@openedx-webhooks
Copy link

@ihor-romaniuk Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@mphilbrick211
Copy link

@ihor-romaniuk FYI above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants