Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form group controls alignment #423

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ihor-romaniuk
Copy link
Contributor

TL;DR -

This pull request contains minor fixes to the display and alignment of form elements for the response options and group feedback block.

What changed?

Before After
image image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 23, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (3aa9088) to head (100b8b2).
Report is 55 commits behind head on main.

❗ Current head 100b8b2 differs from pull request most recent head fdafdbd. Consider uploading reports for the commit fdafdbd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         228      228           
  Lines        4115     4115           
  Branches      822      822           
=======================================
  Hits         3724     3724           
  Misses        370      370           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 requested a review from a team December 11, 2023 19:46
@mphilbrick211
Copy link

Hi @openedx/2u-tnl - would someone be able to please review / merge this for us?

@mphilbrick211 mphilbrick211 requested a review from a team March 21, 2024 01:38
@bydawen bydawen force-pushed the fix/form-elements-alignment branch from 100b8b2 to fdafdbd Compare March 26, 2024 11:47
Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mphilbrick211
Copy link

Hi @connorhaugh - are you able to merge this for us?

@KristinAoki KristinAoki merged commit 6ac0a6e into openedx:main Jun 18, 2024
1 check passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants