-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove thumbnail for non-edX videos & allow removing fallback URLs #505
Conversation
Thanks for the pull request, @bra-i-am! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@bra-i-am Thanks for contributing the fix! We've just moved this repo into https://github.com/openedx/frontend-app-course-authoring/ though; would you mind opening the same fix PR against that repo? Sorry for the extra work. |
@bra-i-am Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
hey @bradenmacdonald, thanks for your answer. It's no problem. I already created the PR there: openedx/frontend-app-authoring#1241 |
Description
This PR aims to solve the issue openedx/frontend-app-authoring#1016 by showing the thumbnail from the
videoSettingsModal
only when theVideo ID
is one given by edX according to this methodAny other
Video ID
will hide the thumbnail:Additionally, this PR fixes a bug when trying to delete a
Fallback video URL
: