Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove thumbnail for non-edX videos & allow removing fallback URLs #505

Closed
wants to merge 2 commits into from

Conversation

bra-i-am
Copy link

Description

This PR aims to solve the issue openedx/frontend-app-authoring#1016 by showing the thumbnail from the videoSettingsModal only when the Video ID is one given by edX according to this method

image

Any other Video ID will hide the thumbnail:

image

Additionally, this PR fixes a bug when trying to delete a Fallback video URL:

image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 28, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 28, 2024

Thanks for the pull request, @bra-i-am!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@bra-i-am bra-i-am marked this pull request as ready for review August 28, 2024 22:17
@bra-i-am bra-i-am changed the title refactor: remove thumbnail to no edX videos & allow removing fallback video urls refactor: remove thumbnail for non-edX videos & allow removing fallback URLs Aug 28, 2024
@bradenmacdonald
Copy link
Contributor

@bra-i-am Thanks for contributing the fix! We've just moved this repo into https://github.com/openedx/frontend-app-course-authoring/ though; would you mind opening the same fix PR against that repo? Sorry for the extra work.

@openedx-webhooks
Copy link

@bra-i-am Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@bra-i-am
Copy link
Author

hey @bradenmacdonald, thanks for your answer. It's no problem. I already created the PR there: openedx/frontend-app-authoring#1241

@bra-i-am bra-i-am deleted the bc/remove-edx-thumbnail branch August 29, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants