Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Search in library content picker searches by draft data #240

Open
ChrisChV opened this issue Nov 18, 2024 · 1 comment
Open

Bug: Search in library content picker searches by draft data #240

ChrisChV opened this issue Nov 18, 2024 · 1 comment
Labels
bug Report of or fix for something that isn't working as intended

Comments

@ChrisChV
Copy link

Search in library content picker searches by draft data and published data, but the expected behavior is to search only by published data.

Steps to reproduce:

  1. Create a library in the Authoring MFE.
  2. Create a component in your library with a name like "This is a test".
  3. Publish the library.
  4. Edit the component in your library, like "Edited component".
  5. Go to a unit in a course and add library content.
  6. Select your library and search by "This is a test", your component appears on the result.
  7. Search by "Edited component", your component appears on the result. This should not happen since you are searching for your draft title, which can confuse the user.
@bradenmacdonald bradenmacdonald added the bug Report of or fix for something that isn't working as intended label Nov 19, 2024
@bradenmacdonald
Copy link
Contributor

@ChrisChV CC @jmakowski1123

Personally I think this is fine. It might be unclear why those search results are appearing, but it's still only showing the published content to the user, and it's not missing any results (which would be a major problem). It's like if a person changed their name when they get married, you appreciate it if you can look them up by either their old name or their new name when you search, even if it only shows the new name.

We are going to revisit this whole thing anyways in a future story: openedx/frontend-app-authoring#1517 . I personally recommend just leaving this as-is for now, but I've copied @jmakowski1123 in case she thinks it's worth changing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: In grooming
Development

No branches or pull requests

2 participants