Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] feat: ensure reference design tokens don't include .value #1989

Merged
merged 1 commit into from
Feb 8, 2023
Merged

[BD-46] feat: ensure reference design tokens don't include .value #1989

merged 1 commit into from
Feb 8, 2023

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Jan 31, 2023 •
edited
Loading

Description

Ensure reference design tokens don't include .value #1968
Issue - #1968

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Jan 31, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 90.41% // Head: 90.41% // No change to project coverage 👍

Coverage data is based on head (ed55fb7) compared to base (9fb7e98).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #1989   +/-   ##
=======================================
  Coverage   90.41%   90.41%           
=======================================
  Files         192      192           
  Lines        3120     3120           
  Branches      746      746           
=======================================
  Hits         2821     2821           
  Misses        283      283           
  Partials       16       16

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request Jan 31, 2023
Closed
@adamstankiewicz adamstankiewicz linked an issue Feb 1, 2023 that may be closed by this pull request
Ensure reference design tokens don't include .value #1968
Closed
@adamstankiewicz adamstankiewicz merged commit 5b7ecf2 into openedx:alpha Feb 8, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

viktorrusakov pushed a commit to viktorrusakov/paragon that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @viktorrusakov
feat: deleted value in reference design tokens (openedx#1989)
222d4e5
adamstankiewicz pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @adamstankiewicz
feat: deleted value in reference design tokens (#1989)
f4b584b
adamstankiewicz pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @adamstankiewicz
feat: deleted value in reference design tokens (#1989)
ef45708
adamstankiewicz pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @adamstankiewicz
feat: deleted value in reference design tokens (#1989)
d1b38de
adamstankiewicz pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @adamstankiewicz
feat: deleted value in reference design tokens (#1989)
f42aea9
edx-requirements-bot pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @github-actions
feat: deleted value in reference design tokens (#1989)
03e7c85
edx-requirements-bot pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @github-actions
feat: deleted value in reference design tokens (#1989)
bbd554f
edx-requirements-bot pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @github-actions
feat: deleted value in reference design tokens (#1989)
221e3a2
edx-requirements-bot pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @github-actions
feat: deleted value in reference design tokens (#1989)
e2d5c16
edx-requirements-bot pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @github-actions
feat: deleted value in reference design tokens (#1989)
c01bbdd
edx-requirements-bot pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @github-actions
feat: deleted value in reference design tokens (#1989)
5b58581
edx-requirements-bot pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @github-actions
feat: deleted value in reference design tokens (#1989)
468c17f
edx-requirements-bot pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @github-actions
feat: deleted value in reference design tokens (#1989)
dd1e13d
edx-requirements-bot added a commit that referenced this pull request Feb 17, 2023
@edx-requirements-bot @adamstankiewicz
@viktorrusakov @PKulkoRaccoonGang
chore(release): sync from master to alpha (#2054)
dd5d3a4 
* build: switch base to trying a rebase (#2047)

* build: pull from alpha before rebase master (#2049)

* build: git checkout instead of git switch (#2051)

* build: set base branch to alpha (#2053)

* feat: alpha release of design tokens (#1770)

* build: add alpha/beta to release CI workflow

* feat: design tokens with style-dictionary

BREAKING CHANGE: Introduces design tokens.

* [BD-46] resolve bootstrap conflicts with design tokens (#1800)

* feat: resolve some Bootstrap conflicts with design tokens

Co-authored-by: Peter Kulko <93188219+PKulkoRaccoonGang@users.noreply.github.com>

* feat: add ability to generate CSS utility classes through design tokens

* docs: added background-color for color HEX values on CSS utility classes page

* fix: add missed border utilities

* docs: add ability to view CSS variables on CSS Utility Classes page

* chore: remove unused import

* feat: remove deprecated components

BREAKING CHANGE: all of the deprecated components were removed from Paragon, these include `CheckBoxGroup`, `Checkbox`, `Fieldset`, `Input`, `InputSelect`, `InputText`, `ListBox`, `Modal`, `RadioButtonGroup`, `StatusAlert`, `Table`, `TextArea`, `ValidationFormGroup`, `Button.Deprecated`, `Tabs.Deprecated`, `Dropdown.Deprecated`.

* chore: update tokens for Modal components

* docs: display computed CSS variables on components' pages

* refactor: update design tokens structure

* feat: add CLI interface for design tokens (#1846)

* fix: install dependencies in tokens module after installing Paragon

* fix: remove package.json files from tokens module

* refactor: update design tokens structure

* refactor: replace old tables with `DataTable` on documentation site (#1859)

* [BD-46] refactor: improve design tokens architecture (#1874)

* refactor: update design tokens naming and add missing ones

* feat: expose replace vars script to CLI

Co-authored-by: Viktor Rusakov <vrusakov66@gmail.com>

* build: add workflow_dispatch to alpha branch to trigger release

* fix: trigger release

* fix: added custom title for CSS output files (#1985)

* feat: deleted value in reference design tokens (#1989)

* fix: ensure design tokens have a valid type attribute (#1992)

Adds `type` attribute to all design tokens per W3C design tokens spec.

* fix: add missing tokens for Button component (#1924)

* feat: add new tokens and cleanup after rebase

* feat: alpha release of design tokens (#1770)

* feat: design tokens with style-dictionary

BREAKING CHANGE: Introduces design tokens.

* [BD-46] resolve bootstrap conflicts with design tokens (#1800)

* feat: resolve some Bootstrap conflicts with design tokens

Co-authored-by: Peter Kulko <93188219+PKulkoRaccoonGang@users.noreply.github.com>

* feat: add ability to generate CSS utility classes through design tokens

* docs: added background-color for color HEX values on CSS utility classes page

* fix: add missed border utilities

* docs: add ability to view CSS variables on CSS Utility Classes page

* chore: remove unused import

* feat: remove deprecated components

BREAKING CHANGE: all of the deprecated components were removed from Paragon, these include `CheckBoxGroup`, `Checkbox`, `Fieldset`, `Input`, `InputSelect`, `InputText`, `ListBox`, `Modal`, `RadioButtonGroup`, `StatusAlert`, `Table`, `TextArea`, `ValidationFormGroup`, `Button.Deprecated`, `Tabs.Deprecated`, `Dropdown.Deprecated`.

* chore: update tokens for Modal components

* refactor: update design tokens structure

* feat: add CLI interface for design tokens (#1846)

* fix: install dependencies in tokens module after installing Paragon

* fix: remove package.json files from tokens module

* refactor: update design tokens structure

* [BD-46] refactor: improve design tokens architecture (#1874)

* refactor: update design tokens naming and add missing ones

* feat: expose replace vars script to CLI

Co-authored-by: Viktor Rusakov <vrusakov66@gmail.com>

* fix: trigger release

* feat: deleted value in reference design tokens (#1989)

* fix: ensure design tokens have a valid type attribute (#1992)

Adds `type` attribute to all design tokens per W3C design tokens spec.

* fix: add missing tokens for Button component (#1924)

* Revert "chore(release): sync from master to alpha (#2040)"

This reverts commit 14ba07c.

* feat: add new tokens and cleanup after rebase

---------

Co-authored-by: Adam Stankiewicz <agstanki@gmail.com>
Co-authored-by: Viktor Rusakov <52399399+viktorrusakov@users.noreply.github.com>
Co-authored-by: Peter Kulko <93188219+PKulkoRaccoonGang@users.noreply.github.com>
Co-authored-by: Viktor Rusakov <vrusakov66@gmail.com>
adamstankiewicz pushed a commit that referenced this pull request Feb 17, 2023
@PKulkoRaccoonGang @adamstankiewicz
feat: deleted value in reference design tokens (#1989)
4ad58f7
adamstankiewicz pushed a commit that referenced this pull request Feb 20, 2023
@PKulkoRaccoonGang @adamstankiewicz
feat: deleted value in reference design tokens (#1989)
645d1bc
monteri pushed a commit to raccoongang/paragon that referenced this pull request Aug 17, 2023
@PKulkoRaccoonGang
feat: deleted value in reference design tokens (openedx#1989)
76b270f
PKulkoRaccoonGang added a commit to raccoongang/paragon that referenced this pull request Aug 18, 2023
@PKulkoRaccoonGang
feat: deleted value in reference design tokens (openedx#1989)
30ca259
PKulkoRaccoonGang added a commit that referenced this pull request Aug 1, 2024
@PKulkoRaccoonGang
feat: deleted value in reference design tokens (#1989)
c600eb7
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
@PKulkoRaccoonGang
feat: deleted value in reference design tokens (#1989)
8084187
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
@PKulkoRaccoonGang
feat: deleted value in reference design tokens (#1989)
3794ee7
PKulkoRaccoonGang added a commit that referenced this pull request Aug 5, 2024
@PKulkoRaccoonGang
feat: deleted value in reference design tokens (#1989)
8ebe4b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorrusakov viktorrusakov viktorrusakov approved these changes

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha
Projects
No open projects
2U Blended Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure reference design tokens don't include .value
5 participants
@PKulkoRaccoonGang @openedx-webhooks @edx-semantic-release @adamstankiewicz @viktorrusakov