Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot migrate $grid-gutter-width with CLI tool #2532

Closed
adamstankiewicz opened this issue Aug 11, 2023 · 3 comments
Closed

Cannot migrate $grid-gutter-width with CLI tool #2532

adamstankiewicz opened this issue Aug 11, 2023 · 3 comments

Comments

@adamstankiewicz
Copy link
Member

As well, I found that $grid-gutter-width is not being replaced I think should be included beside the custom media replacement or do you think should be managed as a Paragon issue? @adam Stankiewicz

@dcoa
Copy link
Contributor

dcoa commented Aug 18, 2023

Giving more context:

Some MFE use $grid-gutter-width as a second or third parameter like frontend-app-authn, but the actual regex only validates the beginning, that's why the replace command doesn't change the variable.

image

@khudym
Copy link
Contributor

khudym commented Sep 20, 2023

PR: #2636

@viktorrusakov
Copy link
Contributor

@dcoa @adamstankiewicz This was fixed in a couple of PRs and a final fix is available in v22.0.0-alpha.5. Note however that you need to add -t usage to the command for it to work, i.e. after installing @edx/paragon@v22.0.0-alpha.5 you need to run replace-scss-with-css -p ./src -t usage in the root of the repo (I don't think there is a proper documentation for this right now, we'll probably need to add that as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants