-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: fixed border-radius of buttons with sizes lg and sm #2786
[BD-46] fix: fixed border-radius of buttons with sizes lg and sm #2786
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2786 +/- ##
==========================================
+ Coverage 92.83% 92.87% +0.03%
==========================================
Files 235 235
Lines 4245 4268 +23
Branches 1032 1033 +1
==========================================
+ Hits 3941 3964 +23
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
f9940fa
to
ff62ebe
Compare
@adamstankiewicz In this PR, the change We also have a SCSS map, where we use the “focus” key in the open-edx theme. If we need to change the stroke color, we need to change it for all the buttons. In this case, we will get the monotony that we have now (using Do you think we should change the outline color of all buttons from |
9fee659
to
4e3d8ba
Compare
<Button variant="brand" className="mb-2 mb-sm-0">Brand</Button> | ||
<Button variant="outline-brand" className="mb-2 mb-sm-0">Outline Brand</Button> | ||
<Button variant="primary" className="mb-2 mb-sm-0">Primary</Button> | ||
<Button variant="outline-primary" className="mb-2 mb-sm-0">Outline Primary</Button> | ||
<Button variant="tertiary" className="mb-2 mb-sm-0">Tertiary</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: its great to remove utility classes like this as sometimes consumers tend to leave the className
props in when they copy/paste components from the docs site... lol.
Next steps: we'll verify at the next Paragon Working Group. |
4e3d8ba
to
a921ad8
Compare
@adamstankiewicz At the Paragon working group, we agreed on changing the stroke color for buttons when the focus is from |
🎉 This PR is included in version 21.11.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* fix: fixed border-radius of buttons with sizes lg and sm * refactor: refactoring README file * refactor: refactoring after review * refactor: changed button focus stroke color
Description
border-radius
on the focus outline radius;2px
offset for the focus outline;README.md
.Issue: #2550
Deploy Preview
Button component
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist