Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[test] parity::helpers::tests::test_join_set is wrong #10264

Closed
niklasad1 opened this issue Jan 30, 2019 · 0 comments
Closed

[test] parity::helpers::tests::test_join_set is wrong #10264

niklasad1 opened this issue Jan 30, 2019 · 0 comments
Labels
Q0-trivial 🎠 Can be fixed by anyone with access to a computer.
Milestone
2.4

Comments

@niklasad1
Copy link
Collaborator

https://github.com/paritytech/parity-ethereum/blob/master/parity/helpers.rs#L485-#L493 assumes that a HashSet is an ordered collection which it is not and will therefore fail occasionally.

A simple solution would be to sort the Vec<String> before comparing
@niklasad1 niklasad1 added the Q0-trivial 🎠 Can be fixed by anyone with access to a computer. label Jan 30, 2019
@niklasad1 niklasad1 changed the title test/helpers::tests::test_join_set is wrong [test] parity::helpers::tests::test_join_set is wrong Jan 30, 2019
@niklasad1 niklasad1 mentioned this issue Jan 30, 2019
Merged
@5chdn 5chdn added this to the 2.4 milestone Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Q0-trivial 🎠 Can be fixed by anyone with access to a computer.
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
2 participants
@niklasad1 @5chdn