Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[whisper] upgrade to latest parity-crypto and copy/move GCM code #10645

Closed
dvdplm opened this issue May 10, 2019 · 0 comments
Closed

[whisper] upgrade to latest parity-crypto and copy/move GCM code #10645

dvdplm opened this issue May 10, 2019 · 0 comments
Labels
F6-refactor 📚 Code needs refactoring. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.

Comments

@dvdplm
Copy link
Collaborator

dvdplm commented May 10, 2019 •
edited
Loading

As part of an effort to make parity-crypto usable from WASM, the dependency on ring was removed. This also removed the GCM functionality from that crate as the only code that uses it is Whisper.
Upgrade Whisper and the rest of parity-ethereum to the new parity-crypto and move the GCM code needed into Whisper, or, if preferred, into its own mini-crate under utils/.
@dvdplm dvdplm added F6-refactor 📚 Code needs refactoring. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. labels May 10, 2019
@dvdplm dvdplm mentioned this issue May 13, 2019
Merged
@dvdplm dvdplm closed this as completed Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F6-refactor 📚 Code needs refactoring. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvdplm