Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Retesteth compatibility tracker #10844

Closed
jam10o-new opened this issue Jul 5, 2019 · 0 comments
Closed

Retesteth compatibility tracker #10844

jam10o-new opened this issue Jul 5, 2019 · 0 comments
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. F8-enhancement 🎊 An additional feature request. F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. P5-sometimesoon 🌲 Issue is worth doing soon. Q9-epic 🌪 Can only be fixed by John Skeet.
Milestone

Comments

@jam10o-new
Copy link
Contributor

jam10o-new commented Jul 5, 2019

Tracking issue for potential https://github.com/ethereum/retesteth support in parity-ethereum.

RPC methods(source):
[?] test_setChainParams
(https://wiki.parity.io/JSONRPC-parity_set-module#parity_setchain implements this functionality, but accepts a chainspec file not the actual chain specification json)
[ ] debug_accountRangeAt
[ ] test_mineBlocks
[ ] debug_storageRangeAt
[ ] test_getLogHash(optional)
[?] test_rewindToBlock
(#8259 - not RPC-accessible)
[ ] test_modifyTimestamp
[?] test_importRawBlock
(partially implemented in #10609)

sorpaas

We don't have ways to inject custom logic into RPC (switching RPC based on whether the client is running in testing mode or in real chain mode), so implementing it may require some large refactoring for us.

todr

I think in the past we were considering writing a wrapper process around Parity to actually restart the client / use command line instead of implementing all the methods in the core client. Especially stuff like rewindToBlock already exist in the CLI, but might not be that easy to do within the core client.

Stuff like test_mineBlock, test_modifyTimestamp could also just use eth_submitRawBlock method from the core client and construct the block externaly, so we don't polute the core client with hacks to make it work :)

@jam10o-new jam10o-new added F8-enhancement 🎊 An additional feature request. Q9-epic 🌪 Can only be fixed by John Skeet. F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. labels Jul 5, 2019
@jam10o-new jam10o-new changed the title Retesteth RPC methods tracker Retesteth compatibility tracker Jul 5, 2019
@jam10o-new jam10o-new added this to the 2.7 milestone Jul 11, 2019
@jam10o-new jam10o-new added the P5-sometimesoon 🌲 Issue is worth doing soon. label Aug 15, 2019
@adria0 adria0 added the A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 27, 2020
@adria0 adria0 closed this as completed Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. F8-enhancement 🎊 An additional feature request. F9-meta 🔮 A specific issue for grouping tasks or bugs of a specific category. P5-sometimesoon 🌲 Issue is worth doing soon. Q9-epic 🌪 Can only be fixed by John Skeet.
Projects
None yet
Development

No branches or pull requests

2 participants