Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

epoch_transistion_for does not fail on unequal hashes #10878

Closed
ghost opened this issue Jul 12, 2019 · 2 comments
Closed

epoch_transistion_for does not fail on unequal hashes #10878

ghost opened this issue Jul 12, 2019 · 2 comments
Labels
F2-bug 🐞 The client fails to follow expected behavior. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.

Comments

@ghost
Copy link

ghost commented Jul 12, 2019 •
edited by ghost
Loading

masks #10085

PR #10729 introduced a new problem/bug:

in case of an unequal hash, no error is raised, thus the client continues to operate, despite the chain being corrupted.

Solution

At minimum, return None after the debug-log has been processed.

https://github.com/paritytech/parity-ethereum/pull/10729/files#diff-5bfc0a03ce9eda19d6d3927beaff4945R1006
@debris
Copy link
Collaborator

debris commented Jul 12, 2019

cc @ngotchac

@debris debris added F2-bug 🐞 The client fails to follow expected behavior. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Jul 12, 2019
@ghost ghost mentioned this issue Jul 12, 2019
Closed
@adria0
Copy link

adria0 commented Jul 27, 2020

Closing issue due to its stale state.

@adria0 adria0 closed this as completed Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F2-bug 🐞 The client fails to follow expected behavior. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@debris @adria0