Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Implement EIP-1767 GraphQL API to Ethereum node data #10933

Closed
adamschmideg opened this issue Aug 1, 2019 · 9 comments
Closed

Implement EIP-1767 GraphQL API to Ethereum node data #10933

adamschmideg opened this issue Aug 1, 2019 · 9 comments
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon. Q7-involved 💪 Can be fixed by a team of developers and probably takes some time.
Milestone

Comments

@adamschmideg
Copy link

adamschmideg commented Aug 1, 2019

This is a feature request.

The current JSON RPC API has shortcomings, so EIP 1767, a GraphQL interface is proposed. It's implemented and released by Geth 1.9.0 and Pantheon, and it's in progress for Trinity. Also, feel free to join the discussion on EIP 1767.

@jam10o-new jam10o-new added F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon. Q7-involved 💪 Can be fixed by a team of developers and probably takes some time. labels Aug 1, 2019
@jam10o-new jam10o-new added this to the 2.8 & .. milestone Aug 1, 2019
@seunlanlege seunlanlege self-assigned this Aug 26, 2019
@adamschmideg
Copy link
Author

I put together an almost-client-agnostic test suite. Replace init-and-run.sh with a parity-specific script and you're ready to run the tests against your implementation. Beware, some test cases have issues, they are listed in the README, but the others are fine.
You can also join the graphql.eth Slack channel if you have any questions about using it.

@liamaharon
Copy link

Any update on this?

@seunlanlege
Copy link
Member

blocked on graphql-rust/juniper#2

@adamschmideg
Copy link
Author

@seunlanlege I understand you're waiting for the linked GraphQL library to have an async implementation. Isn't it an option to use the library as is now, then revisit this once they'll have async?

@seunlanlege
Copy link
Member

unfortunately no, light client uses async code for fetching data from full nodes.
If i did that now, i'd have to refactor to async later.
I'd rather this work be done at once.

@adamschmideg
Copy link
Author

adamschmideg commented Dec 5, 2019

Yeah, it makes perfect sense. Thanks for the update.

@seunlanlege seunlanlege removed their assignment Mar 23, 2020
@adria0 adria0 added the A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 27, 2020
@adria0 adria0 closed this as completed Jul 27, 2020
@liamaharon
Copy link

@adria0 why was this closed? OpenEthereum not planning on implementing a GraphQL interface?

@adria0
Copy link

adria0 commented Jul 28, 2020

Hi @liamaharon, I hope that somebody wants to implement this, unfortunately, all current developers now are just focused on fixing blocking bugs.

@liamaharon
Copy link

Thanks for the clarification @adria0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon. Q7-involved 💪 Can be fixed by a team of developers and probably takes some time.
Projects
None yet
Development

No branches or pull requests

5 participants