Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

add newPendingTransactions to subscriptions #6426

Closed
tzapu opened this issue Aug 31, 2017 · 4 comments
Closed

add newPendingTransactions to subscriptions #6426

tzapu opened this issue Aug 31, 2017 · 4 comments
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. F8-enhancement 🎊 An additional feature request. M6-rpcapi 📣 RPC API. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone

Comments

@tzapu
Copy link
Contributor

tzapu commented Aug 31, 2017

Before filing a new issue, please provide the following information.

I'm running:

  • Parity version: Parity//v1.7.0-beta-5f2cabd-20170727/x86_64-linux-gnu/rustc1.18.0
  • Operating system: Linux

Your issue description goes here below. Try to include actual vs. expected behavior and steps to reproduce the issue.


actual
when trying to subscribe for new pending transactions you get a not implemented message

> {"method":"eth_subscribe","params":["newPendingTransactions"],"id":1,"jsonrpc":"2.0"}
< {"jsonrpc":"2.0","error":{"code":-32000,"message":"This request is not implemented yet. Please create an issue on Github repo."},"id":1}
>

expected
to be able to subscribe for new pending transactions

thank you

@5chdn 5chdn added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M6-rpcapi 📣 RPC API. P7-nicetohave 🐕 Issue is worth doing eventually. labels Aug 31, 2017
@5chdn 5chdn added the F8-enhancement 🎊 An additional feature request. label Sep 27, 2017
@5chdn 5chdn added this to the 1.9 milestone Oct 5, 2017
@5chdn 5chdn modified the milestones: 1.9, 1.10 Oct 17, 2017
@artemii235
Copy link

Hello. Please note that for compatibility with web3.js this subscription should be called just pendingTransactions: https://web3js.readthedocs.io/en/1.0/web3-eth-subscribe.html#subscribe-pendingtransactions. Thanks!

@tomusdrw
Copy link
Collaborator

tomusdrw commented Nov 28, 2017

Will probably be implemented together with transaction queue refactoring --> First part: #6994

@k06a
Copy link

k06a commented Dec 8, 2017

web3.eth.subscribe('pendingTransactions', function(error, result) {
    console.log(error);
})
.on('data', function(txData){
    web3.eth.getTransaction(txData).then(console.log);
});

=>

This request is not implemented yet. Please create an issue on Github repo.

@tzapu
Copy link
Contributor Author

tzapu commented Feb 27, 2018

this works lovely 👍

@5chdn 5chdn modified the milestones: 1.11, 1.10 Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. F8-enhancement 🎊 An additional feature request. M6-rpcapi 📣 RPC API. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

5 participants