Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Return appropriate error when data>300kb for own transactions #8417

Closed
Tbaut opened this issue Apr 17, 2018 · 4 comments
Closed

Return appropriate error when data>300kb for own transactions #8417

Tbaut opened this issue Apr 17, 2018 · 4 comments
Assignees
@grbIzl
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M2-config 📂 Chain specifications and node configurations. M6-rpcapi 📣 RPC API. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone
2.1 Whatever

Comments

@Tbaut
Copy link
Contributor

Tbaut commented Apr 17, 2018

Following discussions at #8301

The limitation currently is imposed on the network layer (see MAX_TRANSACTION_SIZE) and we just ignore incoming transactions larger than 300kb, probably would be good to:

  • return error for own transactions exceeding that limit (additional check in verification pipeline)
  • make it configurable (spec?)
@Tbaut Tbaut added P7-nicetohave 🐕 Issue is worth doing eventually. F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M6-rpcapi 📣 RPC API. M2-config 📂 Chain specifications and node configurations. labels Apr 17, 2018
@Tbaut Tbaut added this to the 1.11 milestone Apr 17, 2018
@debris
Copy link
Collaborator

debris commented Apr 17, 2018

@grbIzl could you look into this?

@grbIzl
Copy link
Collaborator

grbIzl commented Apr 17, 2018

Sure!

@grbIzl grbIzl self-assigned this Apr 17, 2018
@grbIzl grbIzl mentioned this issue Apr 24, 2018
Merged
@5chdn 5chdn modified the milestones: 1.11, 1.12, 1.13 Apr 24, 2018
@folsen
Copy link
Contributor

folsen commented May 21, 2018

@grbIzl Did your PR fix this issue? If so please close.

@grbIzl
Copy link
Collaborator

grbIzl commented May 22, 2018

Closed by #8473

@grbIzl grbIzl closed this as completed May 22, 2018
@debris debris mentioned this issue Jul 15, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grbIzl grbIzl

Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M2-config 📂 Chain specifications and node configurations. M6-rpcapi 📣 RPC API. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Milestone
2.1 Whatever
Development

No branches or pull requests
5 participants
@folsen @debris @grbIzl @5chdn @Tbaut