Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update oe_whitelabel_helper readme requirements section #208

Closed
kp77 opened this issue Feb 10, 2023 · 0 comments · Fixed by #211
Closed

Update oe_whitelabel_helper readme requirements section #208

kp77 opened this issue Feb 10, 2023 · 0 comments · Fixed by #211

Comments

@kp77
Copy link

kp77 commented Feb 10, 2023

Some hard dependencies were removed in 1c6da23, but the helper module's readme still says the following about them:

To be able to enable this module you will have to provide the dependent modules in your projects composer.json

I think the text should be updated to reflect that these packages doesn't necessarily have to be required for the module to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OEL-2257: Updated readme file for whitelabel helper module. openeuropa/oe_whitelabel
1 participant
@kp77