Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reposition eu-footer items with openeuropa/oe_corporate_blocks version 4.19.0 and above #289

Closed
peterserfozo opened this issue Jun 14, 2024 · 1 comment · Fixed by #290
Closed
Labels
bug Something isn't working

Comments

@peterserfozo
Copy link
Contributor

peterserfozo commented Jun 14, 2024

In the 4.19.0 release of https://github.com/openeuropa/oe_corporate_blocks
the EU institutions links are removed and there is only one link points to Search all institutions and bodies
See: https://github.com/openeuropa/oe_corporate_blocks/pull/152/files#diff-65e9d844cb6b349019f8a6c94cf3fea6a0d7ee80f71a88de0d062c5635417416L21-L74

For better alignment and to match ECL the Legal section should be moved to the top right position.

Before the openeuropa/oe_corporate_blocks update:
Screenshot 2024-06-14 at 12 46 48

After the openeuropa/oe_corporate_blocks update:
Screenshot 2024-06-14 at 12 51 24

After the openeuropa/oe_corporate_blocks update and with the proposed change in #290:
Screenshot 2024-06-14 at 12 52 53

@peterserfozo
Copy link
Contributor Author

Note that the padding between the two columns was not set on mobile screen. The PR fixes this issue too by adding a top padding to the first label in the second column only on mobile screen.
Before:
Screenshot 2024-06-14 at 13 34 17

After:
Screenshot 2024-06-14 at 13 36 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants