Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The header pattern displays an empty navbar when both regions are empty #50

Closed
kp77 opened this issue Nov 22, 2021 · 1 comment
Closed

Comments

@kp77
Copy link

kp77 commented Nov 22, 2021

If both the Header left and Header right regions are empty, the header pattern still displays an empty navbar.

image

Currently I'm fixing this by overriding /templates/patterns/header/pattern-header.html.twig and adding this conditional in the override template:

  {% if header_left is not empty or header_right is not empty %}
    {% block content %}
      {{ content }}
    {% endblock %}
  {% endif %}

See: https://github.com/openeuropa/oe_whitelabel/blob/1.x/templates/patterns/header/pattern-header.html.twig#L40-L42

@brummbar
Copy link
Contributor

We removed the header pattern as not useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants