Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional support for Go modules via build-arg for "go" template #189

Closed
alexellis opened this issue Jan 24, 2020 · 4 comments · Fixed by #194
Closed

Add optional support for Go modules via build-arg for "go" template #189

alexellis opened this issue Jan 24, 2020 · 4 comments · Fixed by #194
Assignees

Comments

@alexellis
Copy link
Member

Add optional support for Go modules via build-arg for "go" template

Expected Behaviour

Should be able to pass this and use Go modules:

faas-cli build --build-arg GO111MODULE=on

Current Behaviour

We just support using a vendor folder at present, or using go modules to get a vendor folder, then turning it off for the build.

Possible Solution

See the golang-middleware template as an example and replicate 1:1

https://github.com/openfaas-incubator/golang-http-template/tree/master/template/golang-middleware

Also copy the approach for golang-armhf.

@alexellis
Copy link
Member Author

I'd like an experienced OpenFaaS contributor to take on this work who can also give an estimated time of completion.

@alexellis
Copy link
Member Author

/assign: Waterdrips

@alexellis
Copy link
Member Author

Alistair is away for a bit, so if someone can get to this, please do

@LucasRoesler
Copy link
Member

/assign: me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants