Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Typo] Node template naming in README is wrong #277

Closed
cactysman opened this issue Jan 20, 2022 · 1 comment · Fixed by #278
Closed

[Typo] Node template naming in README is wrong #277

cactysman opened this issue Jan 20, 2022 · 1 comment · Fixed by #278

Comments

@cactysman
Copy link
Contributor

cactysman commented Jan 20, 2022 •
edited
Loading

Hey there, 081622a added new Node.js templates to the README document, but they're are all named node14 instead of node16 and node17,

See:

templates/README.md

Lines 19 to 20 in d8893af

| node14 | NodeJS | 16 | Alpine Linux | of-watchdog | [NodeJS template](https://github.com/openfaas/templates/tree/master/template/node16)
| node14 | NodeJS | 17 | Alpine Linux | of-watchdog | [NodeJS template](https://github.com/openfaas/templates/tree/master/template/node17)

I was about to create a pull request, but the contributing guide told me not to, so here's the issue. 😃
@LucasRoesler
Copy link
Member

@cactysman feel free to send the PR

@cactysman cactysman mentioned this issue Jan 20, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed mismatching node template names in README
2 participants
@LucasRoesler @cactysman