From 1f7a00edf890d8147288ee932b774dca3ef70804 Mon Sep 17 00:00:00 2001 From: Jim Anderson Date: Mon, 23 Sep 2024 14:28:31 -0500 Subject: [PATCH] remove redundant test --- tests/index.test.ts | 20 -------------------- tests/telemetry/configuration.test.ts | 2 -- 2 files changed, 22 deletions(-) diff --git a/tests/index.test.ts b/tests/index.test.ts index 06cbbcb..9867ab0 100644 --- a/tests/index.test.ts +++ b/tests/index.test.ts @@ -272,26 +272,6 @@ describe("OpenFGA SDK", function () { }) ).toThrow(); }); - - it("should only accept valid telemetry metrics", async () => { - - expect( - () => - new OpenFgaApi({ - ...baseConfig, - telemetry: { - metrics: { - histogramRequestDuration: { - attributes: new Set - }, - counterCredentialsRequest: { - attributes: ["JUNK"] as any - }, - } - } - }) - ).toThrow(); - }); }); describe("error handling", () => { diff --git a/tests/telemetry/configuration.test.ts b/tests/telemetry/configuration.test.ts index 1723a16..cab9be9 100644 --- a/tests/telemetry/configuration.test.ts +++ b/tests/telemetry/configuration.test.ts @@ -84,6 +84,4 @@ describe("TelemetryConfiguration", () => { ]))); expect(config.metrics.histogramRequestDuration?.attributes).toEqual(TelemetryConfiguration.defaultAttributes); }); - - // TODO verify behavior for only specifying some of the metrics, what should the others be set to? });