Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "host" option to openfisca-serve #634

Closed
bonjourmauko opened this issue Mar 26, 2018 · 0 comments · Fixed by #771
Closed

Add a "host" option to openfisca-serve #634

bonjourmauko opened this issue Mar 26, 2018 · 0 comments · Fixed by #771
Assignees
Labels
kind:feat A feature request, a feature deprecation level:starter Suited for beginners and new contributors scope:developer-experience

Comments

@bonjourmauko
Copy link
Member

bonjourmauko commented Mar 26, 2018

Imported from openfisca/openfisca-web-api#132 by @Morendil.

When using the openfisca serve script, I can specify a port but not a host to bind to; the script defaults to localhost which is appropriate only in a narrow range of conditions. It will for instance prevent usage from a Docker container, a throwaway virtual machine on a cloud provider, or that home NAS that you use as a server for tinkering with stuff.

Possibly a better default is 0.0.0.0, a pseudo-host which will result in the server socket binding on every available interface. Alternately, a config option --host to override localhost is perfectly suitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat A feature request, a feature deprecation level:starter Suited for beginners and new contributors scope:developer-experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants