Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect /parameter/path.to.param to parameter/path/to/param #695

Closed
fpagnoux opened this issue Jul 24, 2018 · 3 comments
Closed

Redirect /parameter/path.to.param to parameter/path/to/param #695

fpagnoux opened this issue Jul 24, 2018 · 3 comments
Labels
kind:feat A feature request, a feature deprecation
Milestone

Comments

@fpagnoux
Copy link
Member

fpagnoux commented Jul 24, 2018

Depends on #694

The /parameter/path.to.param route is deprecated. Use a 301 to redirect it to the proper new route parameter/path/to/param

This is a breaking change, as clients which do not follow redirects may break if using the old path.

@fpagnoux fpagnoux added this to the v24 milestone Jul 24, 2018
@fpagnoux fpagnoux changed the title Redirect /parameter/path.to.param to parameter/path/to/param Redirect /parameter/path.to.param to parameter/path/to/param Jul 24, 2018
@fpagnoux fpagnoux added kind:feat A feature request, a feature deprecation flow:qualified-issues labels Jul 24, 2018
@MattiSG
Copy link
Member

MattiSG commented Aug 1, 2018

I'll just add that not following redirects in an API is much more common than one would expect, as many server-side request libraries do not do it by default to prevent blocking.

@Morendil
Copy link
Contributor

At the moment both forms are working, and it seems to me like this is just fine. We need only three lines of code to try both routes, and redirecting would likely not save any implementation complexity. In sum, I don't see much value in this issue, recommend closing. Any objections?

@fpagnoux
Copy link
Member Author

fpagnoux commented Dec 4, 2018

Agreeing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat A feature request, a feature deprecation
Projects
None yet
Development

No branches or pull requests

3 participants