Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(UI): right-align all submit buttons. change color of Done buttons #1068

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Nov 30, 2024

What

After some extensive price-adding with Justin this weekend, first of a few PRs to sightly improve the UI.

Submit buttons :

  • always right-align (people hold their phones with their right hand... though I'm left-handed ^^)
  • avoid confusion between Submit & Done buttons

Screenshot

Page Before After
Add multiple prices image image

@raphodn raphodn changed the title refactor: right-align all submit buttons. change color of Done buttons refactor(UI): right-align all submit buttons. change color of Done buttons Nov 30, 2024
@raphodn raphodn added the UI label Nov 30, 2024
@raphodn raphodn merged commit 492b628 into master Nov 30, 2024
9 of 10 checks passed
@raphodn raphodn deleted the raphodn/ui-submit-right branch November 30, 2024 19:55
@raphodn
Copy link
Member Author

raphodn commented Dec 1, 2024

A nice-to-have idea could also be to allow the user to set which side (left or right) are the submit buttons ^^

edit: created an issue: #1077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp the price addition workflow
1 participant