feat: #465 - new "limit" parameter for autocomplete suggestions

[monsieurtanuki]

Impacted files:

• api_get_automcompleted_suggestions.dart: additional test about the new limit parameter.
• openfoodfacts.dart: new limit parameter for autocomplete suggestions.

What

• New limit parameter for autocomplete suggestions.
• Before that, the limit was always 25 suggestions max.
• Now the limit is a parameter. There's a max limit of 400 set on the server side.

Fixes bug(s)

• Closes Autocomplete suggestions limited to 25: not enough! #465

Part of

• Add network-supported autocomplete wherever possible in edit mode smooth-app#2380

[M123-dev]

Thanks @monsieurtanuki looks good, a simple assert for values over 400 could be added but that's not a priority

[monsieurtanuki]

Thank you @M123-dev for your review!
IMHO adding an assert would not be a great idea: we don't want the app to crash because we're not able to deliver on the server side. A warning would make sense - I've put one in the comment, and I don't know how we could add one in the code, given that we don't know which tools the developers use.

[M123-dev]

Flutter enables assertions in debug mode.

AFAIK they are ignored in builds

[monsieurtanuki]

@M123-dev To me assert means something is really wrong, like "dividing by zero", and that the algorithm upstream is flawed ("this value should never be 0, or even then, we should have handle the 0 case before").
Here it's just that if ever there are more than 400 items on the server side that match the search, we'll return only (!) 400 items.
Following this logic we should rather assert that the value is positive. Anyway, that's the beauty of open source: if the developers find it strange that a negative value or a value greater than 400 does not fully work, they can have a look at the code.