Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing #77

Closed
1 task
teolemon opened this issue Jan 29, 2022 · 2 comments · Fixed by #88
Closed
1 task

Tests are failing #77

teolemon opened this issue Jan 29, 2022 · 2 comments · Fixed by #88

Comments

@teolemon
Copy link
Member

teolemon commented Jan 29, 2022

What

  • Tests are failing

Run # stop the build if there are Python syntax errors or undefined names
./draft.py:61:6: E999 SyntaxError: invalid syntax
with # with_additives
^
./openfoodfacts/init.py:74:13: F821 undefined name 'products'
setattr(products, func.name, func)
^
./openfoodfacts/init.py:89:13: F821 undefined name 'products'
setattr(products, func_all.name, func_all)
^
1 E999 SyntaxError: invalid syntax
2 F821 undefined name 'products'
3
Error: Process completed with exit code 1.

Part of

@aadarsh-ram
Copy link
Contributor

Hi @teolemon,
Regarding the F821 error, it seems there's a bug in pyflakes.
The E999 error is part of the draft.py file. I don't think it is being used anywhere inside the whole package. So, I think it can be safely removed.

Please do share your feedback regarding this.

@aadarsh-ram
Copy link
Contributor

@teolemon This issue has been resolved with PR #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants