feat(main): correct and add label logos #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have the existing URLs point to .org production domain instead of .net staging domain. Point to SVG if available, otherwise use the PNG version. Images taken as linked on the main Open Food Facts site. Thanks to Alexandre F and @hangy for providing guidance on fixing this. Signed-off-by: Nico Rikken <nico@nicorikken.eu>
Sort JSON data to more easily detect if labels are missing or already are present. Signed-off-by: Nico Rikken <nico@nicorikken.eu>
|
I'd like to improve this pull-request by including all labels currently requested by Hunger Games for which an image is available. Maybe somebody here can provide me that list? |
Add more label logo's based on experience using the Hunger app. Signed-off-by: Nico Rikken <nico@nicorikken.eu>
nicorikken
force-pushed
the
feature/label-logos
branch
from
f6798d9 to
249dda0
Compare
|
Thank you for contribution! I'm merging it, you can add new logos in a future PR |
|
Here is the info you requested, obtained in production with: SELECT value_tag, COUNT(*) as count
FROM product_insight
WHERE
type = 'label' and bounding_box IS NOT NULL
GROUP BY value_tag
ORDER BY count DESC;
|
|
@raphael0202 thank you so much for the query result, that will help me prioritize additional contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Correct and provide label logo's.
At the moment some logo's couldn't be loaded in Hunger Games. These logo's are important to assist users matching logo's and help to guarantee data quality. Trying out Hunger Games some labels came up that didn't have logo's, so some of those are added too.
See individual commits for more details.
Screenshot
Hunger Games on mobile with logo that couldn't be loaded, showing placeholder text 'logo example' instead. Popover shows URL of image that couldn't be loaded.
Fixes bug(s)
Not applicable
Part of
Not applicable