Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Theme Extensions #1825

Closed
M123-dev opened this issue May 12, 2022 · 8 comments
Closed

Use Theme Extensions #1825

M123-dev opened this issue May 12, 2022 · 8 comments

Comments

@M123-dev
Copy link
Member

M123-dev commented May 12, 2022

Problem

With Flutter 3.0 Google announced a new Feature called "Theme extensions" which allows ThemeData to be extended with custom values. As we have a lot of custom functions for handling our various stlyes we whould make use of this feature and should unify all this.

https://docs.google.com/document/d/1LbD4JqBgAfHex02oR3r2jyu9lTBBNBmyec2ovT59Kr8/edit#heading=h.pub7jnop54q0

Non blocking, we can take care of that after the release

Part of

@BhuvanAde
Copy link
Contributor

As a UI/UX Designer and a Flutter developer I believe I can work on this. So, can I take up this issue?

@M123-dev
Copy link
Member Author

M123-dev commented Dec 6, 2022

Sure @BhuvanAde but as this is a relatively old issue and things have changed a lot since then, what did you have in mind

@BhuvanAde
Copy link
Contributor

BhuvanAde commented Dec 7, 2022

Yes, I think we can give it a shot. I see some places where we could use for more custom values as well. Between @M123-dev what are your thoughts on this?

@M123-dev
Copy link
Member Author

M123-dev commented Dec 9, 2022

The initial idea was to have some constants for padding and such in the ThemeData class, but we managed to solve this problem using global constants in .\packages\smooth_app\lib\generic_lib\design_constants.dart and I think we can leave it like that. The names will get way too long if we put them in the ThemeData class.

Though I've seen your work in your website, what suggestions do you have for the app

@BhuvanAde
Copy link
Contributor

BhuvanAde commented Dec 10, 2022

Yes, I understand! I went through the app. I noticed that we can make the profile section more enticing by making minor UI/UX changes. Please let me know if we can work on this.

@BhuvanAde
Copy link
Contributor

Hello @M123-dev, could you please suggest some issues for me to work on?

@M123-dev
Copy link
Member Author

Sorry for my late answer @BhuvanAde I didn't had much time to contribute to this project.

You can check out these lists:

Besides that here is a list ranked by priority:

And if you are more interested on working UI/UX mocks at least from my personal opinion has the settings tab potential to improved. If you have ideas for this feel free to open a issue with them or share them on Slack 😄

@BhuvanAde
Copy link
Contributor

Thanks @M123-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants